1364613 - Disable replace-malloc on hazard builds

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Mike Hommey [:glandium]]

Replace-malloc is a nightly-only feature which causes problems with the heap write analysis (see https://queue.taskcluster.net/v1/task/SWbCUjxnQeOf_U0QAALfzw/runs/0/artifacts/public/build/heapWriteHazards.txt.gz), and it has a known cost that is not really necessary to analyse automatically.

That will avoid having to add exceptions for it.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1364613 - Disable replace-malloc on hazard builds.

This avoids some known hazard from replace-malloc itself, and unhides
--disable-replace-malloc hazards if there are any (and there is one from
bug 1361258), which wouldn't be caught until riding trains
(replace-malloc being only enabled on nightly).

The hazard from bug 1361258 that disappears is this one:
  Error: Indirect call malloc_hook_table_t.jemalloc_thread_local_arena_hook
  Location: replace_jemalloc_thread_local_arena @memory/replace/replace/ReplaceMalloc.cpp#261
  Stack Trace:
  jemalloc_thread_local_arena @ memory/build/replace_malloc.c#287
  Gecko_SetJemallocThreadLocalArena @ layout/style/ServoBindings.cpp#2062

The new hazard from that bug is:
  Error: Variable assignment jemalloc.c:arenas_map
  Location: jemalloc_thread_local_arena @memory/mozjemalloc/jemalloc.c#3068
  Stack Trace:
  Gecko_SetJemallocThreadLocalArena @ layout/style/ServoBindings.cpp#2048

Where arenas_map is a thread-local variable, so there really is no
hazard.

Review commit: https://reviewboard.mozilla.org/r/139614/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139614/

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8868031 [details]
Bug 1364613 - Disable replace-malloc on hazard builds.

https://reviewboard.mozilla.org/r/139614/#review143244

Great, thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be8ef91f497c
Disable replace-malloc on hazard builds. r=sfink

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/be8ef91f497c