Remove _fillTrailingGap

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Tabbed Browser
P1
normal
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 2 bugs, {perf})

Trunk
Firefox 55
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [photon-performance])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a month ago
This was working around some old XUL layout weirdness, but nowadays this uses the same scroll frame implementation as HTML and as I understand it, tabStrip.scrollPosition + tabStrip.scrollClientSize > tabStrip.scrollSize cannot be true.
(Assignee)

Updated

a month ago
Keywords: perf
(Assignee)

Updated

a month ago
Duplicate of this bug: 935241
Comment hidden (mozreview-request)
(Assignee)

Comment 3

a month ago
mozreview-review
Comment on attachment 8867452 [details]
Bug 1364661 - Remove _fillTrailingGap.

https://reviewboard.mozilla.org/r/139010/#review142294

::: browser/base/content/test/general/browser_tabopen_reflows.js
(Diff revision 1)
> -  // SessionStore.getWindowDimensions()
> -  "ssi_getWindowDimension@resource:///modules/sessionstore/SessionStore.jsm|" +
> -    "ssi_updateWindowFeatures/<@resource:///modules/sessionstore/SessionStore.jsm|" +
> -    "ssi_updateWindowFeatures@resource:///modules/sessionstore/SessionStore.jsm|" +
> -    "ssi_collectWindowData@resource:///modules/sessionstore/SessionStore.jsm|",
> -

FYI, bug 1358809 removed this reflow.

::: devtools/client/responsive.html/docs/browser-swap.md
(Diff revision 1)
>        * Emit `EndSwapDocShells`
>      * `gBrowser.mTabProgressListener`
>      * `filter.addProgressListener`
>      * `ourBrowser.webProgress.addProgressListener`
>    * `gBrowser._endRemoveTab`
> -    * `gBrowser.tabContainer._fillTrailingGap`

Not really sure what this file is...
(Assignee)

Updated

a month ago
Duplicate of this bug: 975009

Updated

a month ago
Flags: qe-verify?
(Assignee)

Updated

a month ago
Flags: qe-verify? → qe-verify-

Comment 5

a month ago
mozreview-review
Comment on attachment 8867452 [details]
Bug 1364661 - Remove _fillTrailingGap.

https://reviewboard.mozilla.org/r/139010/#review142316

Nice! :-)
Attachment #8867452 - Flags: review?(florian) → review+

Comment 6

a month ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55ec58fcd793
Remove _fillTrailingGap. r=florian
https://hg.mozilla.org/mozilla-central/rev/55ec58fcd793
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Updated

a month ago
Iteration: --- → 55.5 - May 15
You need to log in before you can comment on or make changes to this bug.