1364731 - Intermittent svg/smil/anim-gradient-attr-presence-01.svg == svg/smil/anim-gradient-attr-presence-01.svg | image comparison, max difference: 1, number of differing pixels: 4736

Status: RESOLVED FIXED

(Core :: SVG, defect, P4)

Description

[Treeherder Bug Filer]

Filed by: archaeopteryx [at] coole-files.de

https://treeherder.mozilla.org/logviewer.html#?job_id=98954674&repo=autoland

https://queue.taskcluster.net/v1/task/IsNqlt03Qt6LekiH-bjH6w/runs/0/artifacts/public/test_info//reftest-stylo_errorsummary.log

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/IsNqlt03Qt6LekiH-bjH6w/runs/0/artifacts/public/test_info//reftest-stylo_errorsummary.log&only_show_unexpected=1

Comment 1

[Intermittent Failures Robot]

18 failures in 777 pushes (0.023 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 8
* autoland: 7
* mozilla-central: 2
* try: 1

Platform breakdown:
* linux64-stylo-sequential: 12
* linux64-stylo: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1364731&startday=2017-05-15&endday=2017-05-21&tree=all

Comment 2

[Intermittent Failures Robot]

23 failures in 891 pushes (0.026 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 12
* mozilla-inbound: 7
* try: 3
* mozilla-central: 1

Platform breakdown:
* linux64-stylo-sequential: 12
* linux64-stylo: 8
* windows7-32-vm: 2
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1364731&startday=2017-05-22&endday=2017-05-28&tree=all

Comment 3

[Intermittent Failures Robot]

18 failures in 149 pushes (0.121 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 13
* mozilla-inbound: 4
* mozilla-central: 1

Platform breakdown:
* linux64-stylo: 14
* linux64-stylo-sequential: 3
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1364731&startday=2017-06-02&endday=2017-06-02&tree=all

Comment 4

[Intermittent Failures Robot]

66 failures in 820 pushes (0.08 failures/push) were associated with this bug in the last 7 days. 

This is the #17 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 36
* mozilla-inbound: 20
* mozilla-central: 8
* try: 2

Platform breakdown:
* linux64-stylo: 47
* linux64-stylo-sequential: 17
* linux64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1364731&startday=2017-05-29&endday=2017-06-04&tree=all

Comment 5

[Geoff Brown [:gbrown]]

This test is already fuzzy-if'd at https://dxr.mozilla.org/mozilla-central/rev/cad53f061da634a16ea75887558301b77f65745d/layout/reftests/svg/smil/reftest.list#241 - including stylo might be an easy win here.

Comment 6

[Geoff Brown [:gbrown]]

(In reply to Geoff Brown [:gbrown] from comment #5)
> This test is already fuzzy-if'd at
> https://dxr.mozilla.org/mozilla-central/rev/
> cad53f061da634a16ea75887558301b77f65745d/layout/reftests/svg/smil/reftest.
> list#241 - including stylo might be an easy win here.

Actually, this failure has a much greater # of different pixels -- all the edges.

Comment 7

[Geoff Brown [:gbrown]]

:hiro - This started failing shortly after bug 1357295 -- related?

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Yes, of course, this is related to bug 1367327, but the failure frequency raised after bug 1367327?  It's really odd, since bug 1367327 changed stroke-width parser to match to gecko's behavior.

Comment 9

[Geoff Brown [:gbrown]]

This started failing on May 14, shortly after bug 1357295 landed, and increased in frequency May 28, a couple of days after bug 1367327 landed (but that was a weekend, and the increase was "only" about 2x, so, its hard to say if the increase was related to 1367327).

Comment 10

[Joel Maher ( :jmaher ) (UTC -8) (PTO'ish until July 5)]

this week we are on track for the same failure rate as last week.

:hiro, can you pick up fixing this bug?  either random-if or skip-if is ok, possibly there is a real fix we can do.

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1364731 - Specify px unit explicitly.

As of revision 981da978f1f6, on stylo unitless length for stroke-width is
parsed as Number whereas unitless lengths for width and transform are parsed
as app units. These differences seem to cause color differences on the boundary
between grid border lines (specified by stroke-width) and contents'
gradients (specified transform and width).
To avoid these differenes, we should specify px unit.

Review commit: https://reviewboard.mozilla.org/r/147856/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147856/

Comment 12

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=707c277953deb33e6acc677c99cc56c852297ee4

Comment 13

[Brian Birtles (:birtles)]

Comment on attachment 8876530 [details]
Bug 1364731 - Specify px unit explicitly.

https://reviewboard.mozilla.org/r/147856/#review152198

I'm fine with doing this in the interests of enabling this test, but I also feel like we may as well just fix the underlying issue (precision of lengths in transform lists) and not touch this test.

Comment 14

[Brian Birtles (:birtles)]

(In reply to Brian Birtles (:birtles) from comment #13)
> Comment on attachment 8876530 [details]
> Bug 1364731 - Specify px unit explicitly.
> 
> https://reviewboard.mozilla.org/r/147856/#review152198
> 
> I'm fine with doing this in the interests of enabling this test,

Actually, now I see this is an intermittent failure. In that case this is totally fine!

Comment 15

[Intermittent Failures Robot]

45 failures in 864 pushes (0.052 failures/push) were associated with this bug in the last 7 days. 

This is the #31 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-inbound: 27
* autoland: 11
* try: 4
* mozilla-central: 3

Platform breakdown:
* linux64-stylo: 35
* linux64-stylo-sequential: 9
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1364731&startday=2017-06-05&endday=2017-06-11&tree=all

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3118b9ee9db8
Specify px unit explicitly. r=birtles

Comment 17

[Hiroyuki Ikezoe (:hiro)]

Leaving ni to me here since I should provide a test case which reliably fails due to the precision mismatch.

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3118b9ee9db8