1364814 - Use RAII class to set and restore editor flags

Status: RESOLVED FIXED

Description

[Makoto Kato [:m_kato]]

Before fixing input.value optimization, I would like to add RAII class to set and restore flags and max-length.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1364814 - Use RAII class to set and restore editor flags.

input.value setter removes editor flags and max-length to set value.  To clean up code, I would like to use RAII class to set and restore it.

Actually, when the frame is being destroyed by InsertText, it isn't restored.  But it might be safe since the flags is set again on nsTextEditorState::PrepareEditor by focus.

Review commit: https://reviewboard.mozilla.org/r/139168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139168/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Still struggling with the pain, but becoming better)]

Comment on attachment 8867607 [details]
Bug 1364814 - Use RAII class to set and restore editor flags.

https://reviewboard.mozilla.org/r/139168/#review142440

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a4d93b432d9
Use RAII class to set and restore editor flags. r=masayuki

Comment 4

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/1a4d93b432d9