Fix rounding error in WaveDataDecoder::ProcessDecode()

RESOLVED FIXED in Firefox 55

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
http://searchfox.org/mozilla-central/rev/484d2b7f51b7aed035147bbb4a565061659d9278/dom/media/platforms/agnostic/WAVDecoder.cpp#120

The duration is rounded down to 0 if |frames| is smaller than |mInfo.mRate|. We should call FramesToTimeUnit() instead.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8867635 [details]
Bug 1364834 - Fix rounding error in WaveDataDecoder::ProcessDecode().

https://reviewboard.mozilla.org/r/139218/#review142510
Attachment #8867635 - Flags: review?(jyavenard) → review+
Assignee

Comment 3

2 years ago
Thanks!
Assignee

Updated

2 years ago
Assignee: nobody → jwwang
Priority: -- → P3

Comment 4

2 years ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b822eb070c11
Fix rounding error in WaveDataDecoder::ProcessDecode(). r=jya

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b822eb070c11
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.