Closed Bug 1364860 Opened 3 years ago Closed 3 years ago

JSON with error produces horizontal scrollbar

Categories

(DevTools :: JSON Viewer, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: Oriol, Assigned: Oriol)

Details

Attachments

(1 file)

Give some text that can't be JSON-parsed into an object to the JSON Viewer.
For example, load data:application/json,1
There is an horizontal scrollbar because of

  .jsonParseError {
    width: 100%;
    padding: 10px;
  }
Attachment #8867653 - Flags: review?(odvarko)
Comment on attachment 8867653 [details] [diff] [review]
json-scrollbar.patch

Review of attachment 8867653 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Thanks,
Honza
Attachment #8867653 - Flags: review?(odvarko) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/06dc57c171c8
Avoid horizontal scrollbar in JSON Viewer. r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/06dc57c171c8
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.