1364887 - Prevent aliens from influencing try tasks

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

I think this was the intention, per
  https://bugzilla.mozilla.org/show_bug.cgi?id=1287018#c22

But in practice, SETA is still applied in try, and it confuses people.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1364887: don't run SETA on try pushes;

Review commit: https://reviewboard.mozilla.org/r/139274/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139274/

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

we don't use SETA on try, only mozilla-inbound and autoland.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8867690 [details]
Bug 1364887: don't run SETA on try pushes;

https://reviewboard.mozilla.org/r/139274/#review142540

I think this is ok, but the api for SETA will not return valid data for try pushes; this is good safeguarding though

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Thanks -- yeah, I think the issue that brought this up was the same one we saw over the weekend (all BBB jobs optimized away), but a safeguard doesn't hurt, and will reduce SETA server load by 50% :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38f7bc71c0de
don't run SETA on try pushes; r=jmaher

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for breaking gecko decision task:

https://hg.mozilla.org/integration/autoland/rev/66cf481e6e6b4f2a21e2271871636dbe790ced1d

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=99147982&repo=autoland
> TypeError: 'TransformConfig' object has no attribute '__getitem__'

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8867690 [details]
Bug 1364887: don't run SETA on try pushes;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/139274/diff/1-2/

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

updated version should be better..

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6c98d7ddc3d
don't run SETA on try pushes; r=jmaher

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a6c98d7ddc3d