1364888 - Update from AngularJS 1.5 to 1.6

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P2)

Description

[Ed Morley [:emorley]]

We're currently using 1.5.11.

The 1.6 release includes a number of bug fixes and performance improvements:
https://github.com/angular/angular.js/blob/master/CHANGELOG.md#160-rainbow-tsunami-2016-12-08

Upgrade guide:
https://docs.angularjs.org/guide/migration#migrating-from-1-5-to-1-6

Comment 1

[Cameron Dawson [:camd]]

Attachment: Screenshot 2017-06-22 16.21.44.png

Comment 2

[Cameron Dawson [:camd]]

We are hitting a deprecation warning when upgrading to JQuery 3.0 with the use of ``JQuery.fn.bind`` somewhere in our code.  From the attached screenshot, this looks like it's coming from AngularJS.  Not too surprising since we're on an older version.

When this upgrade happens, please test with the JQuery migration tool: https://jquery.com/upgrade-guide/3.0/#jquery-migrate-plugin

Copy https://code.jquery.com/jquery-migrate-3.0.0.js to the UI vendor directory and add this line to the ``entry-index.js`` file at the end of the vendor section: require('./vendor/jquery-migrate-3.0.0.js');

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8880626 [details]
Screenshot 2017-06-22 16.21.44.png

It turns out the deprecation warnings weren't related to angularjs, but angular-ui-bootstrap - see:
https://github.com/mozilla/treeherder/pull/2505#pullrequestreview-46032579

Bug 1375891 filed for updating that (which can be done prior to updating angularjs itself, and should be less invasive).

Comment 4

[Ed Morley [:emorley]]

The Renovate bot PR for this is here:
https://github.com/mozilla/treeherder/pull/3044

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3073

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8939012 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3073

I've deployed this plus the React 16 PR, plus the Angular UI-router PR all to https://treeherder-prototype.herokuapp.com/ to allow for testing - in case that helps :-)

Comment 7

[Cameron Dawson [:camd]]

Comment on attachment 8939012 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3073

Just one little thing.  Thanks for doing this!!  :)

Comment 8

[Ed Morley [:emorley]]

Comment on attachment 8939012 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3073

I've updated the PR to fix the pre-existing bug - good spot :-)

It's been rebased on master and deployed to prototype for testing, along with PR 3101 (the unused DI parameter one).

Comment 9

[Cameron Dawson [:camd]]

Comment on attachment 8939012 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3073

Works now.  Thanks for doing this upgrade!  :)

Comment 10

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/27e516ff4efe1f4379bcf71c1612501407e21a1d
Bug 1364888 - Stop using deprecated $http callback methods

Angular v1.4.4 deprecated `$http`'s `.success()` and `.error()`
callbacks in favour of `.then()` and `.catch()`. The deprecated forms
are finally removed in Angular 1.6, so we need to stop using them:
https://docs.angularjs.org/guide/migration#-http-

https://github.com/mozilla/treeherder/commit/3ada44e0192d37b4badb4d0756ed105bf5b1b667
Bug 1364888 - Upgrade to AngularJS 1.6

The previous commit switched us away from the deprecated `$http`
callback methods, meaning the only other breaking change that affects
us is the `hashPrefix` change, which we revert by manually setting
it back to the empty string, so that existing URLs still work:
https://docs.angularjs.org/guide/migration#commit-aa077e8

For more details, see:
https://docs.angularjs.org/guide/migration#migrating-from-1-5-to-1-6
https://github.com/angular/angular.js/blob/master/CHANGELOG.md#160-rainbow-tsunami-2016-12-08

Closes #3044.