Closed Bug 1364911 Opened 3 years ago Closed 3 years ago
Wait for the history subview to be populated before opening it
59 bytes, text/x-review-board-request
We should wait for the history subview to be populated before opening it, so that we can transition to its final height directly in bug 1009116.
The Sync view seems to be the only other one that does asynchronous operations, but I believe they involve the network and they're enqueued to previous operations, so we shouldn't wait on them.
Comment on attachment 8867719 [details] Bug 1364911 - Wait for the history subview to be populated before opening it. https://reviewboard.mozilla.org/r/139298/#review142562
Attachment #8867719 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/aed8ff339114 Wait for the history subview to be populated before opening it. r=Gijs
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
after this landed and got merged later we got a lot of failures which are perma failures (https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&bugfiler&noautoclassify&filter-searchStr=OS%20X%2010.10%20debug%20Mochitest%20e10s%20Mochitest%20e10s%20Browser%20Chrome%20M-e10s(bc7)&fromchange=c8840a3a2c3b99270e26709c9549496fa206b8eb&selectedJob=99383604) like https://treeherder.mozilla.org/logviewer.html#?job_id=99383604&repo=mozilla-inbound and also on autoland https://treeherder.mozilla.org/logviewer.html#?job_id=99328914&repo=autoland so backing this out to fix the leak
Backout by firstname.lastname@example.org: https://hg.mozilla.org/mozilla-central/rev/5e81f9511634 Backed out changeset aed8ff339114 for memory leaks and making Bug/test failure bug 1340425 perma fail
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/363d0da6b3bc Wait for the history subview to be populated before opening it. r=Gijs
You need to log in before you can comment on or make changes to this bug.