Closed Bug 1364911 Opened 3 years ago Closed 3 years ago

Wait for the history subview to be populated before opening it

Categories

(Firefox :: Toolbars and Customization, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: Paolo, Assigned: Paolo)

References

Details

Attachments

(1 file)

We should wait for the history subview to be populated before opening it, so that we can transition to its final height directly in bug 1009116.
The Sync view seems to be the only other one that does asynchronous operations, but I believe they involve the network and they're enqueued to previous operations, so we shouldn't wait on them.
Comment on attachment 8867719 [details]
Bug 1364911 - Wait for the history subview to be populated before opening it.

https://reviewboard.mozilla.org/r/139298/#review142562
Attachment #8867719 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aed8ff339114
Wait for the history subview to be populated before opening it. r=Gijs
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/aed8ff339114
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Backout by cbook@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/5e81f9511634
Backed out changeset aed8ff339114 for memory leaks and making Bug/test failure bug 1340425 perma fail
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/363d0da6b3bc
Wait for the history subview to be populated before opening it. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/363d0da6b3bc
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.