1364933 - Be more conservative when using json_dump in transform rules

Status: VERIFIED FIXED

(Socorro :: Backend, task)

Description

[[DEACTIVATED] Adrian Gaudebert]

Since we started sending exceptions that happen during Rule execution to sentry, we have seen three KeyErrors that happen very regularly. Incidentally, it seems sending those exceptions makes the processor substantially slower. We should make sure those exceptions do not happen anymore. 

Errors in sentry: 
- https://sentry.prod.mozaws.net/operations/socorro-prod/issues/604395/
- https://sentry.prod.mozaws.net/operations/socorro-prod/issues/604396/
- https://sentry.prod.mozaws.net/operations/socorro-prod/issues/604397/

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3777

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/3e61f2c9df2fe36b459a78539e902be61acf9d32
Fixes bug 1364933 - Made some Rules more conservative. (#3777)

* Fixes bug 1364933 - Made some Rules more conservative.
This fixes some exceptions that were very frequently occurring in the processor, and that we now see since we have added error reporting. I am fixing those 3 errors at once because they are very similar.

* Verify `modules` is a list or tuple before iterating.

Comment 3

[Peter Bengtsson [:peterbe]]

I see that the KeyErrors that were happening on Sentry stage have ceased.