Closed
Bug 1364979
Opened 7 years ago
Closed 7 years ago
Parser::moduleBody() shouldn't use encodeLatin1 for export names
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
1.21 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
Test case:
---
export {\u{1D6A8}}
---
Reports "SyntaxError: local binding for export '5¨' not found".
|
Assignee | |
Comment 1•7 years ago
|
||
Do we have any syntax error message tests for module errors?
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8874392 -
Flags: review?(jcoppeard)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8874392 [details] [diff] [review] bug1364979.patch Review of attachment 8874392 [details] [diff] [review]: ----------------------------------------------------------------- No we don't.
Attachment #8874392 -
Flags: review?(jcoppeard) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c2f4711c9d7c5e898216a8a1a893dded9170aa5
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/eb6d181cfc97 Don't use Latin-1 when encoding the export name for missing exports. r=jonco
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/eb6d181cfc97
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•