Closed Bug 1364979 Opened 3 years ago Closed 3 years ago

Parser::moduleBody() shouldn't use encodeLatin1 for export names

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(1 file)

Test case:
---
export {\u{1D6A8}}
---

Reports "SyntaxError: local binding for export '5¨' not found".
Attached patch bug1364979.patchSplinter Review
Do we have any syntax error message tests for module errors?
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8874392 - Flags: review?(jcoppeard)
Comment on attachment 8874392 [details] [diff] [review]
bug1364979.patch

Review of attachment 8874392 [details] [diff] [review]:
-----------------------------------------------------------------

No we don't.
Attachment #8874392 - Flags: review?(jcoppeard) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb6d181cfc97
Don't use Latin-1 when encoding the export name for missing exports. r=jonco
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/eb6d181cfc97
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.