1364982 - [skiplist] please add "mozilla::detail::nsStringRepr::First" and ...Last to prefix_signature_re

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

+++ This bug was initially created as a clone of Bug #1364706 +++

Please add mozilla::detail::nsStringRepr::First and mozilla::detail::nsStringRepr::Last (the first of which is the signature of bug 1363262) to https://github.com/mozilla/socorro/blob/master/socorro/siglists/prefix_signature_re.txt

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: link to github pull request

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/ba7365f4777437cf419bef1f89e468ce2144127e
Bug 1364982 - Add mozilla::detail::nsStringRepr::{First,Last} to prefix signature list. (#3778)

Comment 3

[Peter Bengtsson [:peterbe]]

Can we verify this is working on crash-stats.allizom.org?

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

Peter, can you make the results of this search (on prod) be sent to stage? I think you have a tool to do that, right? 

https://crash-stats.mozilla.com/search/?signature=~mozilla%3A%3Adetail%3A%3AnsStringRepr%3A%3AFirst&product=Firefox&date=%3E%3D2017-05-09T14%3A04%3A00.000Z&date=%3C2017-05-16T14%3A04%3A00.000Z&_sort=-date&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports

Otherwise, I can't find any crash with these signatures on stage, sadly.

Comment 5

[Peter Bengtsson [:peterbe]]

https://crash-stats.allizom.org/report/index/21c134c6-906e-4218-9a1b-6744e0170511
https://crash-stats.allizom.org/report/index/e0441878-ff4f-4a39-a8b0-adfbd0170511
https://crash-stats.allizom.org/report/index/c31b59bd-54b1-4008-bf38-94bf10170510
https://crash-stats.allizom.org/report/index/1729d43c-169e-49e2-868f-cf8e70170510
https://crash-stats.allizom.org/report/index/dcb9515e-68a2-4a18-bda0-e8e140170510
https://crash-stats.allizom.org/report/index/a807ab76-c001-49af-a6d5-04eef0170510
https://crash-stats.allizom.org/report/index/96cba1d8-e3bb-4221-8057-a828f0170510

Comment 6

[Peter Bengtsson [:peterbe]]

I can't verify this on stage. I still see `mozilla::detail::nsStringRepr::First` in the signatures. 
I reprocessed them all in case that was necessary.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The signatures in comment 5 are exactly what I wanted them to be.  They're now:
  [@ mozilla::detail::nsStringRepr::First | nsCommandLine::HandleFlagWithParam ]
rather than just:
  [@ mozilla::detail::nsStringRepr::First ]

Comment 8

[Peter Bengtsson [:peterbe]]

Verified in stage and this is going into prod right now.

Comment 9

[Peter Bengtsson [:peterbe]]

Thanks :dbaron