Closed Bug 1365026 Opened 9 years ago Closed 9 years ago

Don't include places/arrow-down.svg on other GTK platforms

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
Unspecified
FreeBSD
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file)

Bug 1365026 - Skip places/arrow-down.svg on other Gtk platforms as well.
59 bytes, text/x-review-board-request
dao
: review+
Details
XP_LINUX is almost always wrong for toolkit-specific code, an expected confusion since bug 842913. arrow-down.svg doesn't seem to be used under browser/themes/linux/ which is shared by all Gtk platforms. https://hg.mozilla.org/integration/autoland/rev/01ae37c9efc0#l6.12 http://searchfox.org/mozilla-central/rev/484d2b7f51b7/browser/themes/moz.build#14
Oh, I didn't realize that, sorry.
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Comment on attachment 8867917 [details] Bug 1365026 - Skip places/arrow-down.svg on other Gtk platforms as well. https://reviewboard.mozilla.org/r/139396/#review143016
Attachment #8867917 - Flags: review?(dao+bmo) → review+
Assignee: jhofmann → jbeich
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b6e44119b3b4 Skip places/arrow-down.svg on other Gtk platforms as well. r=dao
https://hg.mozilla.org/mozilla-central/rev/b6e44119b3b4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: