1365053 - Color picker no longer works after using the eyedropper

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Julian Descottes [:jdescottes]]

Attachment: colorpicker_bug_after_eyedropper.gif

STRs:
- go to any page
- open the inspector
- find a property with color swatch
- click on the color swatch
- click on the eyedropper
- pick any color on the page
- try to update the color using the color picker gradient

ER: Value should update as we move the cursor on the gradient
AR: Value only updates once

This behavior remains every time you re-open the color picker.

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Bug 1365053 - called `_onEyeDropperDone` once the color is selected;

Review commit: https://reviewboard.mozilla.org/r/147940/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147940/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8876613 [details]
Bug 1365053 - called `_onEyeDropperDone` once the color is selected;

https://reviewboard.mozilla.org/r/147940/#review152426

The fix looks good. 

I wanted to check if a test would be easy to add, but for some reason, mochitests don't seem to work for me locally.
Did you try to add a small test based on devtools/client/inspector/rules/test/browser_rules_eyedropper.js ?

Could be nice to have non regression here :)

Comment 3

[Julian Descottes [:jdescottes]]

Matteo, can you please land this :)

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1365053.patch

Added 2 ok() checks for eyedropperOpen and activeSwatch in browser_rules_eyedropper.js. Will also land this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71f4f2c0ec56
called `_onEyeDropperDone` once the color is selected; r=jdescottes

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/71f4f2c0ec56

Comment 8

[Saheda Reza [:Antora]]

I have reproduced this bug according to (2017-09-12)

Fixing bug is verified on Latest Nightly & Latest Beta--
Build ID    :20170923220337
User Agent  :Mozilla/5.0 (Windows NT 6.1; rv:58.0) Gecko/20100101 Firefox/58.0

Latest Beta--
Build ID   :20170918210324
User Agent :Mozilla/5.0 (Windows NT 6.1; rv:56.0) Gecko/20100101 Firefox/56.0

Tested OS-- Windows7 32bit