1365080 - Replace query_exe('python') with sys.executable

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Gregory Szorc [:gps]]

There is a handful of mozharness code doing "self.query_exe('python')". In bug 1361912, I nuked "self.query_exe('python2.7')" and replaced it (and corresponding config entries) with "sys.executable." We should do the same for "python".

Also, "python" may resolve to Python 2.6 in some environment. So anywhere we are running the mozharness script as Python 2.7 could "downgrade" to Python 2.6 with the current pattern. This is responsible for a backout in bug 1361912, which is how I discovered this behavior.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1365080 - Replace self.query_exe('python') with sys.executable;

mozharness is Python. self.query_exe('python') could resolve to a
different Python interpreter from what mozharness is running as.

In order to promote consistency, always invoke python processes with
the Python being used to run mozharness.

In some cases, this may cause former `python` processes to run as
Python 2.7 instead of 2.6 (since `python` resolves to a 2.6 interpreter
on many systems). It may also result in slightly different Python
binaries being used. But I think sharing interpreters between the
mozharness script and launched processes is logical. So if this causes
problems, I'd like to flush those out.

Review commit: https://reviewboard.mozilla.org/r/139448/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139448/

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8867920 [details]
Bug 1365080 - Replace self.query_exe('python') with sys.executable;

https://reviewboard.mozilla.org/r/139448/#review149900

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8867920 [details]
Bug 1365080 - Replace self.query_exe('python') with sys.executable;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/139448/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6f04897fdda
Replace self.query_exe('python') with sys.executable; r=ted

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df3950d5ce91
Replace self.query_exe('python') with sys.executable; r=ted

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67979a427b75
Backed out changeset b6f04897fdda for mass build bustage

Comment 7

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/df3950d5ce91

Comment 8

[Jordan Lund (:jlund)]

similar bustage as to: https://bugzilla.mozilla.org/show_bug.cgi?id=1361912#c25