Closed
Bug 1365080
Opened 4 years ago
Closed 4 years ago
Replace query_exe('python') with sys.executable
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file)
There is a handful of mozharness code doing "self.query_exe('python')". In bug 1361912, I nuked "self.query_exe('python2.7')" and replaced it (and corresponding config entries) with "sys.executable." We should do the same for "python". Also, "python" may resolve to Python 2.6 in some environment. So anywhere we are running the mozharness script as Python 2.7 could "downgrade" to Python 2.6 with the current pattern. This is responsible for a backout in bug 1361912, which is how I discovered this behavior.
Comment hidden (mozreview-request) |
Comment 2•4 years ago
|
||
mozreview-review |
Comment on attachment 8867920 [details] Bug 1365080 - Replace self.query_exe('python') with sys.executable; https://reviewboard.mozilla.org/r/139448/#review149900
Attachment #8867920 -
Flags: review?(ted) → review+
Comment hidden (mozreview-request) |
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b6f04897fdda Replace self.query_exe('python') with sys.executable; r=ted
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/df3950d5ce91 Replace self.query_exe('python') with sys.executable; r=ted
Backout by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/67979a427b75 Backed out changeset b6f04897fdda for mass build bustage
![]() |
||
Comment 7•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/df3950d5ce91
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment 8•4 years ago
|
||
similar bustage as to: https://bugzilla.mozilla.org/show_bug.cgi?id=1361912#c25
Updated•3 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•