1365128 - Make the sequential stylo talos jobs correctly identify on the Sequential Stylo platform line

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Kim Moir [:kmoir] ET]

will open pr

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

The talos jobs are actually running, but they're showing on the non-sequential Stylo platform line, mixed in with the talos jobs that are supposed to be there: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=stylo%20talos&group_state=expanded&fromchange=3e166b6838931b3933ca274331f9e0e115af5cc0&tochange=3e166b6838931b3933ca274331f9e0e115af5cc0

You'd need to add a new platform similar to https://github.com/mozilla/treeherder/blob/fca154f5f579af3cb7c2ff13cd3e758b481d375a/treeherder/etl/buildbot.py#L65-L72 to get them to correctly select the proper platform. I *think* you would want it to be above the non-sequential stylo platform, or maybe the specificity gained by adding "-sequential" to the regex is enough to get them truly separated.

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] kmoir:bug1365128 > mozilla:master

Comment 3

[Kim Moir [:kmoir] ET]

Attachment: Make the sequential stylo talos jobs correctly identify on the Sequential Stylo platform line

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d180749e106dbb4af562016f1bbfefb219f6ec02
Bug 1365128 - Add support for sequential stylo talos jobs (#2479)

Comment 5

[Ed Morley [:emorley]]

On this push:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=8601af41344897306fc2a851851dd9a4d1a109df&selectedJob=99722360&filter-searchStr=stylo

Some stylo-seq jobs appear on a 'linux64-styloseq opt' row instead.

It looks like some of the jobs use the platform ending '-styloseq' whereas others use '-stylo-sequential'.

Could you take a look?

Comment 6

[Kim Moir [:kmoir] ET]

It's because the platform in taskcluster is linux64-stylo-sequential and in buildbot it is linux64-stylo-seq so they don't line up.  I'll fix this.

Comment 7

[Kim Moir [:kmoir] ET]

Attachment: fix platform name

Comment 8

[Ed Morley [:emorley]]

Comment on attachment 8870537 [details] [review]
fix platform name

Many thanks!

Comment 9

[Kim Moir [:kmoir] ET]

This is fixed in staging.
https://treeherder.allizom.org/#/jobs?repo=mozilla-central

after the next treeherder deploy it should look correct on the production treeherder instance

Comment 10

[Kim Moir [:kmoir] ET]

new treeherder deployed, looks good on m-c
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=e8da7192201e5786614ec49d557e64dffd114ff2