profileStorage.get should return null instead of throwing, and .add should return the newly created guid.

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Form Manager
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: markh, Assigned: markh)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---
Bug Flags:
in-testsuite +
qe-verify -

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [form autofill:M3])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
We'd like .get() to return null on an unknown GUID so we don't need to introspect and exception to determine if it really just means "no record found".

We'd like .add() to return the GUID that was just created to make testing easier.
Comment hidden (mozreview-request)

Comment 2

5 months ago
mozreview-review
Comment on attachment 8867978 [details]
Bug 1365150 - profile.get returns null instead of throwing, .add returns the new GUID.

https://reviewboard.mozilla.org/r/139518/#review142864

Looks good. Thanks.
Attachment #8867978 - Flags: review?(lchang) → review+

Updated

5 months ago
Whiteboard: [form autofill:M3]
Comment hidden (mozreview-request)

Comment 4

5 months ago
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/autoland/rev/d1798333664b
profile.get returns null instead of throwing, .add returns the new GUID. r=lchang

Comment 5

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d1798333664b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox55: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

4 months ago
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.