1365163 - Remove the layout.css.display-flow-root.enabled preference

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Boris Zbarsky [:bzbarsky]]

stylo seems to not support this.

Comment 1

[Matt Brubeck (:mbrubeck)]

Alternately, should we remove this pref before Stylo ships?  It was added in bug 1322191 and has been enabled by default since Firefox 53.0.

Comment 2

[Boris Zbarsky [:bzbarsky]]

If we're pretty sure that we won't have to emergency-disable this thing, we could remove the pref...  I suspect that might be ok.

Comment 3

[Mats Palmgren (inactive)]

Yeah, I think it's ok to remove this pref.

Comment 4

[Matt Brubeck (:mbrubeck)]

Patch to remove the pref:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f69abef2157f02548bd63ffbd493b8ab6a9cebec

As mentioned in bug 1366914, there are still some remaining prefs in nsLayoutUtils.cpp that we will need to deal with eventually.

Comment 5

[Matt Brubeck (:mbrubeck)]

Attachment: Bug 1365163 - Remove pref layout.css.display-flow-root.enabled.

Review commit: https://reviewboard.mozilla.org/r/146256/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146256/

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 8874875 [details]
Bug 1365163 - Remove pref layout.css.display-flow-root.enabled.

https://reviewboard.mozilla.org/r/146256/#review150230

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a313acd4110
Remove pref layout.css.display-flow-root.enabled. r=mats

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1a313acd4110