Closed Bug 1365163 Opened 3 years ago Closed 3 years ago

Remove the layout.css.display-flow-root.enabled preference

Categories

(Core :: CSS Parsing and Computation, enhancement, P2)

53 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bzbarsky, Assigned: mbrubeck)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

stylo seems to not support this.
Priority: -- → P2
Alternately, should we remove this pref before Stylo ships?  It was added in bug 1322191 and has been enabled by default since Firefox 53.0.
If we're pretty sure that we won't have to emergency-disable this thing, we could remove the pref...  I suspect that might be ok.
Flags: needinfo?(mats)
Yeah, I think it's ok to remove this pref.
Flags: needinfo?(mats)
Assignee: nobody → mbrubeck
Patch to remove the pref:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f69abef2157f02548bd63ffbd493b8ab6a9cebec

As mentioned in bug 1366914, there are still some remaining prefs in nsLayoutUtils.cpp that we will need to deal with eventually.
Status: NEW → ASSIGNED
Summary: stylo: Need to support the layout.css.display-flow-root.enabled preference → Remove the layout.css.display-flow-root.enabled preference
Comment on attachment 8874875 [details]
Bug 1365163 - Remove pref layout.css.display-flow-root.enabled.

https://reviewboard.mozilla.org/r/146256/#review150230
Attachment #8874875 - Flags: review?(mats) → review+
Pushed by mbrubeck@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a313acd4110
Remove pref layout.css.display-flow-root.enabled. r=mats
https://hg.mozilla.org/mozilla-central/rev/1a313acd4110
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.