1365166 - rename security.data_uri.inherit_security_context

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

We introduced the name 'security.data_uri.inherit_security_context' in bug 1328860.
However I think the naming is a little confusing,

for example, when we're doing a feature, it's default pref 'off', when the feature is ready, we turn 'on'

But the feature security.data_uri.inherit_security_context now is 'On', and we are going to turn it 'OFF'.

I am guessing this may cause some misunderstanding in the future, specially for release engineering, 

ckerschb, smaug, what do you think?

Thanks

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Yoshi Huang [:allstars.chh] from comment #0)
> ckerschb, smaug, what do you think?

I don't have a strong opinion about that. If you wanna change it, that's fine with me.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

I don't have a strong opinion either.
I see it so that currently we have legacy behavior enabled, and once everything is fixed, we can disable it.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Thanks, then I'll rename it to security.data_uri.unique_opaque_origin and pref default off.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8868405 [details] [diff] [review]
Patch.

>
>+// TODO: Bug 1324406: Treat 'data:' documents as unique, opaque origins
>+// If true, data: URIs will be treated as unique opaque origins, hence will use
>+// a NullPrincipal as the security context.
>+// Otherwise it will inherit the origin from parent node, this is the legacy
>+// behavior of Firefox.
>+pref ("security.data_uri.unique_opaque_origin", false);
Looks like the old code had extra space between pref and (, want to fix it here.

Comment 6

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8868405 [details] [diff] [review]
Patch.

Review of attachment 8868405 [details] [diff] [review]:
-----------------------------------------------------------------

thanks

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cf73dbcd1a0
rename security.data_uri.inherit_security_context to security.data_uri.unique_opaque_origin. r=smaug, ckerschb

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9cf73dbcd1a0