1365169 - Fix margin left for autocomplete-richlistbox

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[magicp]

Attachment: autocomplete-richlistbox.png

[Steps to reproduce]
1. Start latest Nightly (e.g. Build ID: 20170515030205)
2. Enter any words in awesome bar

[Actual Results]
margin left is too large.

[Expected Results]
Back to previous styles.

[Regression Range]
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0645deeb4caa1de3fa2f238005500f77e457eacd&tochange=a46c4ea1cf309c23fa89c06a985d2102a7a0260a

Comment 1

[Johann Hofmann [:johannh]]

This is a side effect of moving some controls to the left of the urlbar, because the autocomplete text aligns horizontally with the urlbar text. I wouldn't call it a regression, but the search team should probably think about whether they want to change this. Panos, needinfo'ing you to make sure search is aware of the issue.

Comment 2

[Johann Hofmann [:johannh]]

(Also note that we will eventually center the urlbar, so this is issue will definitely get worse). Stephen, I haven't seen any Photon urlbar autocomplete mockups yet, did I just miss those? What's the plan there?

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Aligning the results with the typed text has been the intent behind Stephen's current (previous?) design, so this looks fine to me.

Comment 4

[magicp]

Attachment: autocomplete-richlistbox-2.png

(In reply to Panos Astithas [:past] (please needinfo?) from comment #3)
> Aligning the results with the typed text has been the intent behind
> Stephen's current (previous?) design, so this looks fine to me.

If so, attached image case is wrong?

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to magicp from comment #4)
> Created attachment 8869636 [details]
> autocomplete-richlistbox-2.png
> 
> (In reply to Panos Astithas [:past] (please needinfo?) from comment #3)
> > Aligning the results with the typed text has been the intent behind
> > Stephen's current (previous?) design, so this looks fine to me.
> 
> If so, attached image case is wrong?

Drew might know if we ignore alignment when the search bar is moved around.

Comment 6

[Drew Willcoxon :adw]

There's a threshold past which we don't try to align the margin anymore.  I forget what it is exactly.  It may be a number of toolbar items or a number of points/pixels.  But that screenshot definitely hits it. :-)

Good point about what to do when the urlbar is centered, though.

Comment 7

[Drew Willcoxon :adw]

This logic here: https://dxr.mozilla.org/mozilla-central/rev/9851fcb0bf4d855c36729d7de19f0fa5c9f69776/browser/base/content/urlbarBindings.xml#1696

If there are more than two toolbar items between the window edge and the urlbar, then we stop trying to align.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Per the comments above this is working as intended, so resolving this bug.