1365203 - Annotate name of base::Thread in the crash reporter

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[Cervantes Yu [:cyu] [:cervantes]]

Bug 1024669 added thread name annotation in crash reports. We started to see thread names on the server after landing of bug 1358457 and bug 1361380. But some  named threads are still anonymous in the crash report. One example is

https://crash-stats.mozilla.com/report/index/c5559d33-de3f-47b0-b1b3-72eb60170510#allthreads

Where the thread is created using chromium base::Thread class. It's constructor requires a name. We only need to pass this name to crash reporting using NS_SetCurrentThreadName() in nsThreadUtils.h.

Under the hood, we'll attach PRThread to base::Thread, which is used for cleaning up the thread name on thread termination. base::Thread::Stop() really joins the native thread so cleaning up the attached PRThread shouldn't be an issue.

Comment 1

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Part 1 - Annotate name of base::Thread

Comment 2

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Part 2 - Test cases

Comment 3

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8868082 [details] [diff] [review]
Part 1 - Annotate name of base::Thread

Review of attachment 8868082 [details] [diff] [review]:
-----------------------------------------------------------------

Nice and simple, LGTM.

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8868083 [details] [diff] [review]
Part 2 - Test cases

Likewise, test coverage is excellent, thanks Cervantes!

Comment 5

[Cervantes Yu [:cyu] [:cervantes]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/412168e07dd1fa4f0c1839ff90ac60b7a3c69ddc
Bug 1365203 - Annotate name of base::Thread in the crash report. r=gsvelto

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e07ae5b0b69519a59d2943b95534bade9b68758
Bug 1365203 - Test cases for annotating name of base::Thread in the crash reporter. r=gsvelto

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/412168e07dd1
https://hg.mozilla.org/mozilla-central/rev/2e07ae5b0b69