1365204 - Record badge shown and doorhanger shown in separate telemetry histograms

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement, P2)

Description

[Robert Strong (they/them - no direct email)]

Both of these are currently recorded in update_notification_shown. I suggest that update_notification_shown is used for doorhangers since only doorhangers can be dismissed which is already recorded in the update_notification_dismissed histogram. The new histogram for badges being shown could be named update_notification_badge_shown.

Comment 1

[Alex Thayer [:alexical] (she/her)]

To clarify, update_notification_badge_shown would only be recorded if the badge came up by itself, correct? (i.e., not by dismissing a doorhanger.)

Comment 2

[Robert Strong (they/them - no direct email)]

As long as all cases where the badge is shown before the doorhanger will be recorded as update_notification_badge_shown this should be fine. I don't *think* we want to record update_notification_badge_shown for the case when it is shown due to the the doorhanger being dismissed (e.g. update_notification_dismissed), etc. Does that make sense to you?

Comment 3

[Alex Thayer [:alexical] (she/her)]

Yup! Sounds good to me.

Comment 4

[Robert Strong (they/them - no direct email)]

Doug, could you take this bug?

Comment 5

[Alex Thayer [:alexical] (she/her)]

Yup! I was just waiting for 1359733 to land.

Comment 6

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1365204 - Add update badge histogram

Currently we can't differentiate between when a badge is shown
and a doorhanger is shown. This creates an additional problem
where if the badge progresses into a doorhanger after a window of
time has passed, it registers as two notifications shown, when
logically it is one. This splits out badges and doorhangers to
remedy that.

Review commit: https://reviewboard.mozilla.org/r/142468/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142468/

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 8870895 [details]
Bug 1365204 - Add update badge histogram

https://reviewboard.mozilla.org/r/142468/#review146230

::: toolkit/components/telemetry/Histograms.json:5832
(Diff revision 1)
>      "bug_numbers": [893505],
>      "releaseChannelCollection": "opt-out",
>      "description": "Update: the application update doorhanger type that was displayed.",
>      "labels": ["restart", "available", "manual"]
>    },
> +  "UPDATE_NOTIFICATION_BADGE_SHOWN": {

You will need to get a data steward (e.g. bsmedberg, etc.) to approve the new telemetry.

::: toolkit/mozapps/update/UpdateListener.jsm:104
(Diff revision 1)
>  
>      AppMenuNotifications.showNotification("update-" + type,
>                                            action,
>                                            secondaryAction,
>                                            { dismissed, beforeShowDoorhanger });
> +    if (dismissed) {

Took me a minute to realize that dismissed means show the badge and not the doorhanger vs. the doorhanger being dismissed. If I have this wrong please let me know.

Please file a bug for adding java comments for the functions in this file.

Comment 8

[Alex Thayer [:alexical] (she/her)]

Comment on attachment 8870895 [details]
Bug 1365204 - Add update badge histogram

https://reviewboard.mozilla.org/r/142468/#review146230

> Took me a minute to realize that dismissed means show the badge and not the doorhanger vs. the doorhanger being dismissed. If I have this wrong please let me know.
> 
> Please file a bug for adding java comments for the functions in this file.

Added https://bugzilla.mozilla.org/show_bug.cgi?id=1367778

Comment 9

[Benjamin Smedberg]

Comment on attachment 8870895 [details]
Bug 1365204 - Add update badge histogram

https://reviewboard.mozilla.org/r/142468/#review147924

data-r=me (this is a followup to the data from bug 893505, and we're using the data analysis plan described there)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/860549ef693b
Add update badge histogram r=bsmedberg,rstrong

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/860549ef693b