Update the performance settings related strings

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Preferences
P1
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: evanxd, Assigned: evanxd)

Tracking

55 Branch
Firefox 55
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [photon-preference])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Update the performance settings related strings. This is the spec[1].

[1]: https://mozilla.invisionapp.com/share/WGBJOAB76#/screens/230367024_5-1_Performance
Flags: qe-verify+
(Assignee)

Updated

a year ago
Whiteboard: [photon-preference]
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
You would need to update the IDs.
Flags: needinfo?(evan)
Comment hidden (mozreview-request)
(Assignee)

Comment 5

a year ago
Updated it. Thanks for reminding.
Flags: needinfo?(evan)
(Assignee)

Updated

a year ago
Attachment #8868424 - Flags: review?(jaws)
(Assignee)

Comment 6

a year ago
Hi Jared, 

Could you help review the patch?

Thanks.
Comment hidden (mozreview-request)
(Assignee)

Comment 8

a year ago
Update the patch to fix the `browser_misused_characters_in_strings.js` failure.

Comment 9

a year ago
mozreview-review
Comment on attachment 8868424 [details]
Bug 1365210 - Update performance settings strings to align the spec.

https://reviewboard.mozilla.org/r/140010/#review145184
Attachment #8868424 - Flags: review?(jaws) → review+
(Assignee)

Comment 10

a year ago
The try looks good. Let's land the patch.
Keywords: checkin-needed

Comment 11

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b699305f059b
Update performance settings strings to align the spec. r=jaws
Keywords: checkin-needed

Comment 12

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b699305f059b
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED

Comment 13

a year ago
I can see  performance settings related strings is updated according to the spec in Latest nightly 55.0a1 in Ubuntu 16.04,
64 Bit.

Build ID   : 20170607100302
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
QA Whiteboard: [bugday-20170607]

Comment 14

a year ago
I can confirm that the performance settings related strings are updated according to the comment 0 with Latest nightly 55.0a1 on Windows 10 ,64 Bit !

Build ID    20170607030206
User Agent  Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0
 
[bugday-20170607]

Comment 15

a year ago
As per Comment 13 and Comment 14, I am marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.