Closed Bug 1365210 Opened 7 years ago Closed 7 years ago

Update the performance settings related strings

Categories

(Firefox :: Settings UI, defect, P1)

Product:
Firefox
Component:
Settings UI
Version:
55 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: evanxd, Assigned: evanxd)

References

Details

(Whiteboard: [photon-preference])

Attachments

(1 file)

Bug 1365210 - Update performance settings strings to align the spec.
59 bytes, text/x-review-board-request
jaws
: review+
Details 
Update the performance settings related strings. This is the spec[1].

[1]: https://mozilla.invisionapp.com/share/WGBJOAB76#/screens/230367024_5-1_Performance
Flags: qe-verify+
Whiteboard: [photon-preference]
You would need to update the IDs.
Flags: needinfo?(evan)
Updated it. Thanks for reminding.
Flags: needinfo?(evan)
Attachment #8868424 - Flags: review?(jaws)
Hi Jared, 

Could you help review the patch?

Thanks.
Update the patch to fix the `browser_misused_characters_in_strings.js` failure.
Comment on attachment 8868424 [details]
Bug 1365210 - Update performance settings strings to align the spec.

https://reviewboard.mozilla.org/r/140010/#review145184
Attachment #8868424 - Flags: review?(jaws) → review+
The try looks good. Let's land the patch.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b699305f059b
Update performance settings strings to align the spec. r=jaws
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b699305f059b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
I can see  performance settings related strings is updated according to the spec in Latest nightly 55.0a1 in Ubuntu 16.04,
64 Bit.

Build ID   : 20170607100302
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
QA Whiteboard: [bugday-20170607]
I can confirm that the performance settings related strings are updated according to the comment 0 with Latest nightly 55.0a1 on Windows 10 ,64 Bit !

Build ID    20170607030206
User Agent  Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0
 
[bugday-20170607]
As per Comment 13 and Comment 14, I am marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: