Make sure 'this' is captured on dispatch to STS thread in AddRIDExtension_m and AddRIDFilter_m in MediaPipeline

RESOLVED FIXED in Firefox 55

Status

()

Core
WebRTC
P2
normal
Rank:
25
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: mjf, Assigned: mjf)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
These were seen in a drive-by review on Bug 1358224, along with a potential to remove an unnecessary refcnt in MediaPipeline::GetMediaPipelineForTrack.  These are easy fixes.
(Assignee)

Updated

9 months ago
Rank: 25
(Assignee)

Updated

9 months ago
Assignee: nobody → mfroman
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

9 months ago
mozreview-review
Comment on attachment 8868292 [details]
Bug 1365291 - capture 'this' with RefPtr on dispatch to STS thread.

https://reviewboard.mozilla.org/r/139882/#review144166
Attachment #8868292 - Flags: review?(jib) → review+

Comment 5

9 months ago
Pushed by mfroman@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/0f5e027fe25a
capture 'this' with RefPtr on dispatch to STS thread. r=jib

Comment 6

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0f5e027fe25a
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.