Updated Overflow Menu inverts where placed-objects and overflowed-in objects apear

VERIFIED FIXED in Firefox 55

Status

()

defect
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: bbell, Assigned: Gijs)

Tracking

(Blocks 2 bugs)

unspecified
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed, firefox57 verified)

Details

(Whiteboard: [photon-structure])

Attachments

(2 attachments)

Reporter

Description

2 years ago
Posted image example.png
Icons can be manually placed into the overflow menu, these items should appear at the bottom (below the horizontal line).
Reporter

Updated

2 years ago
Assignee: nobody → gijskruitbosch+bugs
Blocks: 1352692
Whiteboard: [photon-structure]
Assignee

Updated

2 years ago
Status: NEW → ASSIGNED
Flags: qe-verify+
Iteration: --- → 55.6 - May 29
Priority: -- → P1
QA Contact: gwimberly
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8868582 [details]
Bug 1365294 - swap position of the fixed overflow list,

https://reviewboard.mozilla.org/r/140186/#review143544

LGTM!

::: browser/components/customizableui/content/panelUI.js:89
(Diff revision 1)
>    // We do this sync on init because in order to have the overflow button show up
>    // we need to know whether anything is in the permanent panel area.
>    _initPhotonPanel() {
>      if (gPhotonStructure) {
>        this.overflowFixedList.hidden = false;
> -      this.overflowFixedList.nextSibling.hidden = false;
> +      this.overflowFixedList.previousSibling.hidden = false;

nit: can you add a short comment that you're un-hiding the separator here?
Attachment #8868582 - Flags: review?(mdeboer) → review+
Comment hidden (mozreview-request)

Comment 4

2 years ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/40ff2188f44f
swap position of the fixed overflow list, r=mikedeboer

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/40ff2188f44f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Updated

2 years ago
Blocks: 1387512
I have tested this on latest nightly, and newly added icons to the overflow menu appear at the bottom of the list.
Updating the bug as verified-fixed.
Status: RESOLVED → VERIFIED

Updated

2 years ago
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.