Closed Bug 1365346 Opened 4 years ago Closed 4 years ago

[jsdbg2] Debugger.Source.prototype.sourceMapURL setter doesn't check argc

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: jimb, Assigned: jimb)

Details

Attachments

(1 file, 1 obsolete file)

The Debugger.Source.prototype.sourceMapURL property setter crashes if passed no arguments.

Not S-S as Debugger is not exposed to content, and this bug is unlikely to be hit by chrome accidentally.
Assignee: nobody → jimb
Status: NEW → ASSIGNED
Attachment #8868227 - Flags: review?(shu)
Comment on attachment 8868227 [details] [diff] [review]
Make Debugger.Source.prototype.sourceMapURL setter check its argc.

Review of attachment 8868227 [details] [diff] [review]:
-----------------------------------------------------------------

Very thorough test.
Attachment #8868227 - Flags: review?(shu) → review+
Rebasing patch, carrying over r=shu
Attachment #8868227 - Attachment is obsolete: true
Keywords: checkin-needed
OS: Unspecified → All
Hardware: Unspecified → All
Target Milestone: --- → mozilla57
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1fa0f399079
Make Debugger.Source.prototype.sourceMapURL setter check its argc. r=shu
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f1fa0f399079
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.