Closed Bug 1365350 Opened 3 years ago Closed 3 years ago

OS X tests are starting before artifacts uploaded

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla55

People

(Reporter: garndt, Assigned: wcosta)

Details

Attachments

(1 file)

Here is a failure:
https://treeherder.mozilla.org/#/jobs?repo=try&author=jmaher@mozilla.com&selectedJob=99473976&filter-searchStr=osx%20other

What appears to happen is that the test is trying to download a file from another task (presumably the build task) but it's not available.  At the time of this writing, the task it relied upon for that artifact is still in a pending state and no artifacts uploaded yet. 

It looks like the tests rely upon the build being complete, but should rather be waiting for the s3 uploader task to finish?
Flags: needinfo?(wcosta)
(In reply to Greg Arndt [:garndt] from comment #0)
> Here is a failure:
> https://treeherder.mozilla.org/#/jobs?repo=try&author=jmaher@mozilla.
> com&selectedJob=99473976&filter-searchStr=osx%20other
> 
> What appears to happen is that the test is trying to download a file from
> another task (presumably the build task) but it's not available.  At the
> time of this writing, the task it relied upon for that artifact is still in
> a pending state and no artifacts uploaded yet. 
> 
> It looks like the tests rely upon the build being complete, but should
> rather be waiting for the s3 uploader task to finish?

That's rather strange, since the uploader task is completed by mozharness before returning to BBB, which completes the build task. Therefore, there is no way to builder task finishes before uploader task.
Flags: needinfo?(wcosta)
Assignee: nobody → wcosta
Status: NEW → ASSIGNED
Comment on attachment 8868241 [details]
Bug 1365350: make uploader task a dependency of tests.

https://reviewboard.mozilla.org/r/139818/#review143220

::: taskcluster/taskgraph/morph.py:195
(Diff revision 1)
>  
>  
>  def update_test_tasks(taskid, build_taskid, taskgraph):
>      """Tests task must download artifacts from uploader task.
>  
>      Notice they don't need to depend on uploader task because it finishes

This comment needs updating
Attachment #8868241 - Flags: review?(garndt) → review+
Pushed by wcosta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79027b4b7762
make uploader task a dependency of tests. r=garndt
Backed out for frequently failing gecko decision task with 'Bad Request':

https://hg.mozilla.org/integration/autoland/rev/35947a63b0ce43ecd1893f83547b5043251fd356

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=79027b4b776213a6f3faf1838b865f3f87800041&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=99768185&repo=autoland

[task 2017-05-17T13:19:18.101436Z] "PUT /queue/v1/task/XyjrtHIYTxWuBQ_GRefFsQ HTTP/1.1" 200 378
[task 2017-05-17T13:19:18.208660Z] "PUT /queue/v1/task/dni6KPjVQI6JbxCYtvjjIg HTTP/1.1" 200 379
[task 2017-05-17T13:19:45.995951Z] "PUT /queue/v1/task/C7e90aDaRz-6UBdnUeNQQw HTTP/1.1" 200 371
[task 2017-05-17T13:19:46.020692Z] Traceback (most recent call last):
[task 2017-05-17T13:19:46.020751Z]   File "/home/worker/checkouts/gecko/taskcluster/mach_commands.py", line 168, in taskgraph_decision
[task 2017-05-17T13:19:46.020789Z]     return taskgraph.decision.taskgraph_decision(options)
[task 2017-05-17T13:19:46.020835Z]   File "/home/worker/checkouts/gecko/taskcluster/taskgraph/decision.py", line 140, in taskgraph_decision
[task 2017-05-17T13:19:46.020867Z]     create_tasks(tgg.morphed_task_graph, tgg.label_to_taskid, parameters)
[task 2017-05-17T13:19:46.020916Z]   File "/home/worker/checkouts/gecko/taskcluster/taskgraph/create.py", line 89, in create_tasks
[task 2017-05-17T13:19:46.021225Z]     f.result()
[task 2017-05-17T13:19:46.021266Z]   File "/home/worker/checkouts/gecko/python/futures/concurrent/futures/_base.py", line 398, in result
[task 2017-05-17T13:19:46.021906Z]     return self.__get_result()
[task 2017-05-17T13:19:46.021952Z]   File "/home/worker/checkouts/gecko/python/futures/concurrent/futures/thread.py", line 55, in run
[task 2017-05-17T13:19:46.022016Z]     result = self.fn(*self.args, **self.kwargs)
[task 2017-05-17T13:19:46.022322Z]   File "/home/worker/checkouts/gecko/taskcluster/taskgraph/create.py", line 108, in create_task
[task 2017-05-17T13:19:46.022361Z]     res.raise_for_status()
[task 2017-05-17T13:19:46.022418Z]   File "/home/worker/checkouts/gecko/python/requests/requests/models.py", line 840, in raise_for_status
[task 2017-05-17T13:19:46.022450Z]     raise HTTPError(http_error_msg, response=self)
[task 2017-05-17T13:19:46.022482Z] HTTPError: 400 Client Error: Bad Request for url: http://taskcluster/queue/v1/task/bI58_4lVS3qncvcA9npMSA
[taskcluster 2017-05-17 13:19:46.383Z] === Task Finished ===
Flags: needinfo?(wcosta)
Comment on attachment 8868241 [details]
Bug 1365350: make uploader task a dependency of tests.

https://reviewboard.mozilla.org/r/139818/#review143646
Attachment #8868241 - Flags: review?(dustin) → review+
Pushed by wcosta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d113a83f2a55
make uploader task a dependency of tests. r=dustin,garndt
https://hg.mozilla.org/mozilla-central/rev/d113a83f2a55
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Flags: needinfo?(wcosta)
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.