Closed Bug 1365375 Opened 6 years ago Closed 6 years ago

Hamburger menu not updated on account destroyed

Categories

(Firefox :: Sync, defect, P1)

Product:
Firefox
Component:
Sync
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: eoger, Assigned: eoger)

Details

Attachments

(1 file)

Bug 1365375 - Disconnect Sync on account destroyed.
59 bytes, text/x-review-board-request
markh
: review+
Details 
Saw this in Sync fest.
Blocks: 1353571
Actually not a regression from bug 1353571, it's always been there.
No longer blocks: 1353571
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 8868748 [details]
Bug 1365375 - Disconnect Sync on account destroyed.

https://reviewboard.mozilla.org/r/140350/#review143710

Looks great to me. I guess this can land before the server's PR lands and is deployed, but please check with rfk first.

::: services/fxaccounts/FxAccountsPush.js:183
(Diff revision 1)
>        case ON_PASSWORD_CHANGED_NOTIFICATION:
>        case ON_PASSWORD_RESET_NOTIFICATION:
>          this._onPasswordChanged();
>          return;
> +      case ON_ACCOUNT_DESTROYED_NOTIFICATION:
> +        this.fxAccounts.handleAccountDestroyed(payload.data.uid);

handleAccountDestroyed returns a promise, so we probably want a .catch(err => {this.log.error("blah", err)
Attachment #8868748 - Flags: review?(markh) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d11aec13b38e
Disconnect Sync on account destroyed. r=markh
Backout by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/30ef16860449
Backed out changeset d11aec13b38e for eslint failures.
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b5150cea5f18
Disconnect Sync on account destroyed. r=markh
https://hg.mozilla.org/mozilla-central/rev/b5150cea5f18
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.