1365375 - Hamburger menu not updated on account destroyed

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Edouard Oger [:eoger]]

Saw this in Sync fest.

Comment 1

[Edouard Oger [:eoger]]

Actually not a regression from bug 1353571, it's always been there.

Comment 2

[Edouard Oger [:eoger]]

Attachment: Bug 1365375 - Disconnect Sync on account destroyed.

This connects to the fxa-auth-server PR:
https://github.com/mozilla/fxa-auth-server/pull/1900

Review commit: https://reviewboard.mozilla.org/r/140350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140350/

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8868748 [details]
Bug 1365375 - Disconnect Sync on account destroyed.

https://reviewboard.mozilla.org/r/140350/#review143710

Looks great to me. I guess this can land before the server's PR lands and is deployed, but please check with rfk first.

::: services/fxaccounts/FxAccountsPush.js:183
(Diff revision 1)
>        case ON_PASSWORD_CHANGED_NOTIFICATION:
>        case ON_PASSWORD_RESET_NOTIFICATION:
>          this._onPasswordChanged();
>          return;
> +      case ON_ACCOUNT_DESTROYED_NOTIFICATION:
> +        this.fxAccounts.handleAccountDestroyed(payload.data.uid);

handleAccountDestroyed returns a promise, so we probably want a .catch(err => {this.log.error("blah", err)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d11aec13b38e
Disconnect Sync on account destroyed. r=markh

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30ef16860449
Backed out changeset d11aec13b38e for eslint failures.

Comment 6

[Edouard Oger [:eoger]]

Comment on attachment 8868748 [details]
Bug 1365375 - Disconnect Sync on account destroyed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/140350/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5150cea5f18
Disconnect Sync on account destroyed. r=markh

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b5150cea5f18