1365398 - preventDefault() during a checkbox click event should revert the checkbox's checkedness

Status: RESOLVED DUPLICATE of bug 1610821

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Domenic Denicola]

See test at http://w3c-test.org/html/semantics/forms/the-input-element/checkbox-click-events.html and spec at around https://html.spec.whatwg.org/#input-activation-behavior

Comment 1

[Jessica Jong [:jessica] (inactive)]

Hmm, our implementation in HTMLInputElement.cpp does follow the spec. But if the element is not connected, we early return in HTMLInputElement::GetEventTargetParent [1] and the default activation behavior is not ran. There is an old bug for this, bug 329509.

So, changing the test a bit by putting the checkbox in the document [2] works.

[1] http://searchfox.org/mozilla-central/rev/9a7fbdee1d54f99cd548af95b81231d80e5f9ad1/dom/html/HTMLInputElement.cpp#3620-3622
[2] https://jsfiddle.net/jessi3py/028b18pj/1/

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Does that mean we should submit a patch to revise that w3c test?

Comment 3

[Jessica Jong [:jessica] (inactive)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #2)
> Does that mean we should submit a patch to revise that w3c test?

Hmm we can do that, but it'd better if we figure out how to fix bug 329509.

Comment 4

[Marcos Caceres [:marcosc]]

Fixed by bug 329509. Tests are all green.

Comment 5

[John Dai[:jdai]]

After fixed bug 329509, we can start fixing the WPT fail in http://w3c-test.org/html/semantics/forms/the-input-element/checkbox-click-events.html.

Comment 6

[John Dai[:jdai]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae9f85b15a42a94bac7e949dc7808b05b2d7f60f

Comment 7

[John Dai[:jdai]]

The WPT[1] has been fixed at bug 1610821.

[1] http://w3c-test.org/html/semantics/forms/the-input-element/checkbox-click-events.html