Closed Bug 1365402 Opened 3 years ago Closed 3 years ago

textarea value property does not normalize CRLF and CR to LF

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: d, Assigned: ben.tian)

References

()

Details

Attachments

(2 files, 2 obsolete files)

See Also: 1300282
Priority: -- → P2
Assignee: nobody → btian
Attachment #8873281 - Flags: review?(amarchesini)
Comment on attachment 8873281 [details]
Bug 1365402 - part 1: Normalize CRLF and CR to LF for textarea value property,

https://reviewboard.mozilla.org/r/144736/#review152330

Canceling the review request.
Attachment #8873281 - Flags: review?(amarchesini)
Comment on attachment 8873281 [details]
Bug 1365402 - part 1: Normalize CRLF and CR to LF for textarea value property,

https://reviewboard.mozilla.org/r/144736/#review152332

Sorry, wrong review request.
Attachment #8873281 - Flags: review?(amarchesini)
Comment on attachment 8873281 [details]
Bug 1365402 - part 1: Normalize CRLF and CR to LF for textarea value property,

https://reviewboard.mozilla.org/r/144736/#review152336

Submit a separate patch for removing extra spaces. r+ for that patch as well
Attachment #8873281 - Flags: review?(amarchesini) → review+
Attach patches with r+ per comment 4, and obsolete mozreview requests for unable to set r+ for patch 2.
Attachment #8873281 - Attachment is obsolete: true
Attachment #8876965 - Attachment is obsolete: true
Attachment #8876965 - Flags: review?(amarchesini)
Attachment #8876967 - Flags: review+
Comment on attachment 8876968 [details] [diff] [review]
Bug 1365402 - part 2: Remove trailing spaces in dom/html/HTMLTextAreaElement.cpp, r=baku

Review of attachment 8876968 [details] [diff] [review]:
-----------------------------------------------------------------

This should be a separate bug.
Attachment #8876968 - Flags: review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ae6c80f5710
part 1: Normalize CRLF and CR to LF for textarea value property, r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/410f73774f02
part 2: Remove trailing spaces in dom/html/HTMLTextAreaElement.cpp, r=baku
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2ae6c80f5710
https://hg.mozilla.org/mozilla-central/rev/410f73774f02
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.