Closed
Bug 1365412
Opened 7 years ago
Closed 7 years ago
Clean up various ESLint global definitions in browser/
Categories
(Firefox :: General, enhancement)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
Partially due to the gradual roll-out of enabling no-undef, and discovering improvements to rules as we went, there's a lot of global definitions around the tree that either: - aren't needed - can be better served by something else (e.g. modules.json addition, eslint-env specification). Hence, I'm looking to start getting those cleaned up before people start copying bad styles.
Assignee | ||
Comment 1•7 years ago
|
||
A couple of other notes: - I'll cover the rest of the tree in separate bugs, as I get to them. - I'm bumping the eslint-plugin-mozilla version as I should push a new version for outside repos to pick up.
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8868290 [details] Bug 1365412 - Clean up various ESLint global definitions in browser/. https://reviewboard.mozilla.org/r/139878/#review143640
Attachment #8868290 -
Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cd7394f9fb58 Clean up various ESLint global definitions in browser/. r=mossop
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cd7394f9fb58
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in
before you can comment on or make changes to this bug.
Description
•