Closed Bug 1365415 Opened 3 years ago Closed 3 years ago
We fail to hook Ldr
Resolve Delay Loaded API on Win7
TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook LdrResolveDelayLoa dedAPI from ntdll.dll
As far as I can tell, the cppunittest failure is benign. LdrResolveDelayLoadedAPI was only introduced in Win8. Win7's delay-load plumbing uses vanilla APIs like LoadLibrary/GetProcAddress, which are already protected by our LdrLoadDll hook. So we shouldn't worry about LdrResolveDelayLoadedAPI on Win7.
Attachment #8868668 - Flags: review?(mstange)
For the record, this wasn't caught in CI because it's specific to 64-bit Windows 7. Our CI currently tests 32-bit Windows 7 and 64-bit Windows 8. Alas.
Attachment #8868668 - Flags: review?(mstange) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/e637503718d9 No need to hook LdrResolveDelayLoadedAPI on Win7, it doesn't exist. r=mstange
You need to log in before you can comment on or make changes to this bug.