Closed Bug 1365415 Opened 3 years ago Closed 3 years ago

We fail to hook LdrResolveDelayLoadedAPI on Win7

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

Details

Attachments

(1 file)

TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook LdrResolveDelayLoa
dedAPI from ntdll.dll
Blocks: 1355559
As far as I can tell, the cppunittest failure is benign. LdrResolveDelayLoadedAPI was only introduced in Win8. Win7's delay-load plumbing uses vanilla APIs like LoadLibrary/GetProcAddress, which are already protected by our LdrLoadDll hook. So we shouldn't worry about LdrResolveDelayLoadedAPI on Win7.
Attachment #8868668 - Flags: review?(mstange)
For the record, this wasn't caught in CI because it's specific to 64-bit Windows 7. Our CI currently tests 32-bit Windows 7 and 64-bit Windows 8. Alas.
Attachment #8868668 - Flags: review?(mstange) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e637503718d9
No need to hook LdrResolveDelayLoadedAPI on Win7, it doesn't exist. r=mstange
https://hg.mozilla.org/mozilla-central/rev/e637503718d9
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.