Add a specific manifest marker for all the unix-like OSes

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(4 attachments)

Assignee

Description

2 years ago
When using chrome entries with alternatives for each OS, what currently do is:
  entry-for-unix
  entry-for-osx os=Darwin
  entry-for-windows os=WINNT

The first doesn't have a marker because there isn't one for !Darwin !WINNT, and it's not possible to do !A && !B logic with those markers.

But for determinism reasons, the chrome manifests entries from jar.mn are sorted (per bug 982075), so one needs to ensure that the order above is preserved after sorting for things to work (because if it's reordered, then the entry with no marker takes precedence on any other that comes before it).

This has hit me in bug 780562, which introduces one of those footguns, but it was already hit in at least Pocket (which in fact only works by chance ; it so happens that they chose "linux" instead of "unix" and that comes before "osx")

Adding an explicit marker for !Darwin !WINNT would be useful (and I guess that shouldn't include Android, too, which should have its own).

Maybe os=Unix and os=Android? I'm not too thrilled about os=Unix, actually, because it wouldn't match what XP_UNIX means in the tree... 
As a matter of fact, we don't have a XP_* for XP_UNIX && !XP_DARWIN && !ANDROID (because android is also part of XP_UNIX).
Flags: needinfo?(benjamin)

Comment 1

2 years ago
I'd suggest lumping all "desktup and !winnt and !darwin" into one os=likeunix parameter. Android should be separate.
Flags: needinfo?(benjamin)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

2 years ago
mozreview-review
Comment on attachment 8871538 [details]
Bug 1365419 - Allow to apply manifest entries for all non-(Darwin,Windows,Android) OSes.

https://reviewboard.mozilla.org/r/143022/#review146980
Attachment #8871538 - Flags: review?(benjamin) → review+

Comment 7

2 years ago
mozreview-review
Comment on attachment 8871539 [details]
Bug 1365419 - Use the new os=LikeUnix flag instead of relying on overrides.

https://reviewboard.mozilla.org/r/143024/#review146982
Attachment #8871539 - Flags: review?(benjamin) → review+

Comment 8

2 years ago
mozreview-review
Comment on attachment 8871540 [details]
Bug 1365419 - Rename global-platform/gtk back to global-platform/unix.

https://reviewboard.mozilla.org/r/143026/#review146984
Attachment #8871540 - Flags: review?(benjamin) → review+

Comment 9

2 years ago
mozreview-review
Comment on attachment 8871563 [details]
Bug 1365419 - Fixup l10n packager after bug 780562.

https://reviewboard.mozilla.org/r/143046/#review148816
Attachment #8871563 - Flags: review?(gps) → review+

Comment 10

2 years ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/1d9b50fadc05
Allow to apply manifest entries for all non-(Darwin,Windows,Android) OSes. r=bsmedberg
https://hg.mozilla.org/integration/autoland/rev/261eecf8497f
Use the new os=LikeUnix flag instead of relying on overrides. r=bsmedberg
https://hg.mozilla.org/integration/autoland/rev/9aafdd1ca0bd
Rename global-platform/gtk back to global-platform/unix. r=bsmedberg
https://hg.mozilla.org/integration/autoland/rev/d82aa6aec2c1
Fixup l10n packager after bug 780562. r=gps
I had to back this out for android mochitest failures like https://treeherder.mozilla.org/logviewer.html#?job_id=103904610&repo=autoland

https://hg.mozilla.org/mozilla-central/rev/28dff773a7ae9ea84ebf96209db2bb7be8548e6e
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla55 → ---
Flags: needinfo?(mh+mozilla)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 17

2 years ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/adb2b2e7960d
Allow to apply manifest entries for all non-(Darwin,Windows,Android) OSes. r=bsmedberg
https://hg.mozilla.org/integration/autoland/rev/960b693323d4
Use the new os=LikeUnix flag instead of relying on overrides. r=bsmedberg
https://hg.mozilla.org/integration/autoland/rev/e8196e56eecc
Rename global-platform/gtk back to global-platform/unix. r=bsmedberg
https://hg.mozilla.org/integration/autoland/rev/3075f34ce6f7
Fixup l10n packager after bug 780562. r=gps
Assignee

Updated

2 years ago
Flags: needinfo?(mh+mozilla)
You need to log in before you can comment on or make changes to this bug.