1365419 - Add a specific manifest marker for all the unix-like OSes

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Mike Hommey [:glandium]]

When using chrome entries with alternatives for each OS, what currently do is:
  entry-for-unix
  entry-for-osx os=Darwin
  entry-for-windows os=WINNT

The first doesn't have a marker because there isn't one for !Darwin !WINNT, and it's not possible to do !A && !B logic with those markers.

But for determinism reasons, the chrome manifests entries from jar.mn are sorted (per bug 982075), so one needs to ensure that the order above is preserved after sorting for things to work (because if it's reordered, then the entry with no marker takes precedence on any other that comes before it).

This has hit me in bug 780562, which introduces one of those footguns, but it was already hit in at least Pocket (which in fact only works by chance ; it so happens that they chose "linux" instead of "unix" and that comes before "osx")

Adding an explicit marker for !Darwin !WINNT would be useful (and I guess that shouldn't include Android, too, which should have its own).

Maybe os=Unix and os=Android? I'm not too thrilled about os=Unix, actually, because it wouldn't match what XP_UNIX means in the tree... 
As a matter of fact, we don't have a XP_* for XP_UNIX && !XP_DARWIN && !ANDROID (because android is also part of XP_UNIX).

Comment 1

[Benjamin Smedberg]

I'd suggest lumping all "desktup and !winnt and !darwin" into one os=likeunix parameter. Android should be separate.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1365419 - Allow to apply manifest entries for all non-(Darwin,Windows,Android) OSes.

Manifest entries can contain flags, one of which allows to match on the
os running Gecko. The match is performed against the value returned by
nsIXULRuntime.getOS, which itself comes from the build-system's
OS_TARGET.

In practice, this means that things like os=WINNT, os=Darwin,
os=Android, os=Linux are valid filters, but the latter is too specific,
and most of the time, one would want something that is "any OS but
WINNT, Darwin, Android", which can't be expressed with manifest entry
flags (there is no "and" for them, only "or").

For convenience, we add the keyword "LikeUnix", which has that meaning.

Review commit: https://reviewboard.mozilla.org/r/143022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143022/

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1365419 - Use the new os=LikeUnix flag instead of relying on overrides.

Since it wasn't possible to have specific manifest entries for !Darwin
!WINNT !Android, a few places in the tree use the following pattern:
   entry-for-unix
   entry-for-osx os=Darwin
   entry-for-windows os=WINNT

This works because subsequent manifest entries with more specific flags
override previous manifest entries.

Incidentally, this led to problems such as the one mentioned in
changeset c94e87a18096.

Now that there is a flag for !Darwin !WINNT !Android, we can use it
instead.

Review commit: https://reviewboard.mozilla.org/r/143024/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143024/

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1365419 - Rename global-platform/gtk back to global-platform/unix.

In case some legacy third-party things were relying on those files being
under a unix/ directory, revert the part of changeset c94e87a18096 that
renamed global-platform/unix to global-platform/gtk.

Review commit: https://reviewboard.mozilla.org/r/143026/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143026/

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1365419 - Fixup l10n packager after bug 780562.

The change to l10n packager from bug 780562 worked in practice because
no chrome category had exclusively manifest entries with flags, which
we're changing in this bug.

It turns out this was only due to a missing change in the patch for bug
780562.

Review commit: https://reviewboard.mozilla.org/r/143046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143046/

Comment 6

[Benjamin Smedberg]

Comment on attachment 8871538 [details]
Bug 1365419 - Allow to apply manifest entries for all non-(Darwin,Windows,Android) OSes.

https://reviewboard.mozilla.org/r/143022/#review146980

Comment 7

[Benjamin Smedberg]

Comment on attachment 8871539 [details]
Bug 1365419 - Use the new os=LikeUnix flag instead of relying on overrides.

https://reviewboard.mozilla.org/r/143024/#review146982

Comment 8

[Benjamin Smedberg]

Comment on attachment 8871540 [details]
Bug 1365419 - Rename global-platform/gtk back to global-platform/unix.

https://reviewboard.mozilla.org/r/143026/#review146984

Comment 9

[Gregory Szorc [:gps]]

Comment on attachment 8871563 [details]
Bug 1365419 - Fixup l10n packager after bug 780562.

https://reviewboard.mozilla.org/r/143046/#review148816

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d9b50fadc05
Allow to apply manifest entries for all non-(Darwin,Windows,Android) OSes. r=bsmedberg
https://hg.mozilla.org/integration/autoland/rev/261eecf8497f
Use the new os=LikeUnix flag instead of relying on overrides. r=bsmedberg
https://hg.mozilla.org/integration/autoland/rev/9aafdd1ca0bd
Rename global-platform/gtk back to global-platform/unix. r=bsmedberg
https://hg.mozilla.org/integration/autoland/rev/d82aa6aec2c1
Fixup l10n packager after bug 780562. r=gps

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1d9b50fadc05
https://hg.mozilla.org/mozilla-central/rev/261eecf8497f
https://hg.mozilla.org/mozilla-central/rev/9aafdd1ca0bd
https://hg.mozilla.org/mozilla-central/rev/d82aa6aec2c1

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for android mochitest failures like https://treeherder.mozilla.org/logviewer.html#?job_id=103904610&repo=autoland

https://hg.mozilla.org/mozilla-central/rev/28dff773a7ae9ea84ebf96209db2bb7be8548e6e

Comment 13

[Mike Hommey [:glandium]]

Comment on attachment 8871538 [details]
Bug 1365419 - Allow to apply manifest entries for all non-(Darwin,Windows,Android) OSes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143022/diff/1-2/

Comment 14

[Mike Hommey [:glandium]]

Comment on attachment 8871539 [details]
Bug 1365419 - Use the new os=LikeUnix flag instead of relying on overrides.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143024/diff/1-2/

Comment 15

[Mike Hommey [:glandium]]

Comment on attachment 8871540 [details]
Bug 1365419 - Rename global-platform/gtk back to global-platform/unix.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143026/diff/1-2/

Comment 16

[Mike Hommey [:glandium]]

Comment on attachment 8871563 [details]
Bug 1365419 - Fixup l10n packager after bug 780562.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143046/diff/1-2/

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adb2b2e7960d
Allow to apply manifest entries for all non-(Darwin,Windows,Android) OSes. r=bsmedberg
https://hg.mozilla.org/integration/autoland/rev/960b693323d4
Use the new os=LikeUnix flag instead of relying on overrides. r=bsmedberg
https://hg.mozilla.org/integration/autoland/rev/e8196e56eecc
Rename global-platform/gtk back to global-platform/unix. r=bsmedberg
https://hg.mozilla.org/integration/autoland/rev/3075f34ce6f7
Fixup l10n packager after bug 780562. r=gps

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/adb2b2e7960d
https://hg.mozilla.org/mozilla-central/rev/960b693323d4
https://hg.mozilla.org/mozilla-central/rev/e8196e56eecc
https://hg.mozilla.org/mozilla-central/rev/3075f34ce6f7