1365425 - [bn-BD] Search engine setup for Firefox Mobile for Bengali (Bangladesh)

Status: RESOLVED FIXED

(Mozilla Localizations :: bn-BD / Bengali, enhancement)

Description

[Delphine Lebédel [:delphine - Use needinfo]]

We want to ship Firefox Mobile with a good list of search engines for Bengali (Bangladesh). Seems like we added bn-BD to single-locale builds without one so we need to fix this before we can ship it.

We're going to work towards this in three phases. First, the localization team and the l10n drivers will look at the market for the language and come up with a good set of search providers. Belayet and bn-BD team, we'll need your input on this, the guidelines for making recommendations are on <https://wiki.mozilla.org/L10n:Mobile/Productization>.

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:

> Google (mobile version), Yahoo, Bing, Amazon, Twitter, Wikipedia (slightly different to desktop, 32x32 icon)

We may also want to go with just a subset of the en-US engines, if that's more appropriate for the local market.

Once we decide to use a particular search engine (and we test it on a mobile device), l10n drivers will contact the owner and ask for permission if it is needed, and for specifics like proper search flags. Belayet and bn-BD team, we'll likely need your help to at least get the contact information.

For search engines that we already ship with on desktop and that you would like to include in mobile as well, the permission is not needed. Consider using a mobile version of the engine if one is available. Also, please make yourself familiar with instructions regarding the <Description/> element at <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions>. For mobile, we'll want 64x64 size images, too.

Once we have a specification on what the search engines for bn-BD should look like, Delphine and the localization team will work on an implementation on that. Delphine will create and attach patches for the desired changes and get them reviewed. After a successful review, Delphine will land them. Belayet and bn-BD team, if you're interested, you could create the patches, too. You'd ask :delphine for review on those before landing.

Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by Delphine or someone else appointed by the l10n drivers. The data here is sensitive to users and our search partners, thus the extra care here.

The bn-BD team and :delphine will be driving this bug to completion.

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Seems like I dropped the ball on this at one point. 

bn-BD team: I will need your help to determine which search plugins to add for your locale (please see Description of the bug for more details on what that may be). Let me know if you have any questions!

Comment 2

[Mahay Alam Khan]

(In reply to Delphine Lebédel [:delphine - use Need Info] from comment #0)
> We want to ship Firefox Mobile with a good list of search engines for
> Bengali (Bangladesh). Seems like we added bn-BD to single-locale builds
> without one so we need to fix this before we can ship it.
> 
> We're going to work towards this in three phases. First, the localization
> team and the l10n drivers will look at the market for the language and come
> up with a good set of search providers. Belayet and bn-BD team, we'll need
> your input on this, the guidelines for making recommendations are on
> <https://wiki.mozilla.org/L10n:Mobile/Productization>.
> 
> For en-US, we currently use this set, to which we can fall back in the case
> of lacking localized alternatives:
> 
> > Google (mobile version), Yahoo, Bing, Amazon, Twitter, Wikipedia (slightly different to desktop, 32x32 icon)
> 
> We may also want to go with just a subset of the en-US engines, if that's
> more appropriate for the local market.
> 
> Once we decide to use a particular search engine (and we test it on a mobile
> device), l10n drivers will contact the owner and ask for permission if it is
> needed, and for specifics like proper search flags. Belayet and bn-BD team,
> we'll likely need your help to at least get the contact information.
> 
> For search engines that we already ship with on desktop and that you would
> like to include in mobile as well, the permission is not needed. Consider
> using a mobile version of the engine if one is available. Also, please make
> yourself familiar with instructions regarding the <Description/> element at
> <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions>. For mobile,
> we'll want 64x64 size images, too.


do we need to provide localized images for local search engines, if we suggest any?

> 
> Once we have a specification on what the search engines for bn-BD should
> look like, Delphine and the localization team will work on an implementation
> on that. Delphine will create and attach patches for the desired changes and
> get them reviewed. After a successful review, Delphine will land them.
> Belayet and bn-BD team, if you're interested, you could create the patches,
> too. You'd ask :delphine for review on those before landing.
> 
> Please don't commit any modifications in browser/searchplugins to the hg
> repository without a patch reviewed by Delphine or someone else appointed by
> the l10n drivers. The data here is sensitive to users and our search
> partners, thus the extra care here.
> 
> The bn-BD team and :delphine will be driving this bug to completion.

Comment 3

[bellayet]

I have talked with bn-BD localization team, our decission on search plugins,

*Global general search:
Google BD (google.com.bd)

*Reference search:
Bengali Wikipedia (bn.wikipedia.org)
English Wikipedia (en.wikipedia.org)

*E-commerce search:
AjkerDeal (https://ajkerdeal.com/

*Social search:
Facebook

Comment 4

[Delphine Lebédel [:delphine - Use needinfo]]

Thanks for the feedback!

A few comments: 
* Google: I believe that I should only add the generic "google", but I need to check (haven't seen any other locales that have a local google - or maybe that's what google-nocodes does? Not sure)
* AjkerDeal: Actually I'm not sure we can add custom E-commerce search, so going to ask too. That said, if we can add customized  E-commerce too, then we first need to get Business Development's approval. This usually takes time so I'd suggest we go without it at first, while we wait for the permission.
* Facebook: we don't add Facebook in the search plugins

Asking flod so he can help clarify the 2 first points.

Concerning the question about localized images: you only need to provide an icon if you're asking for a locale searchplugin that's not already included.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Delphine Lebédel [:delphine - use Need Info] from comment #4)
> * Google: I believe that I should only add the generic "google", but I need
> to check (haven't seen any other locales that have a local google - or maybe
> that's what google-nocodes does? Not sure)

Yes, we only ship one Google and let it do the language redirect, based on user preferences (if you're logged in) or user language settings. google-nocodes is for countries where Google is not the default.

> * AjkerDeal: Actually I'm not sure we can add custom E-commerce search, so
> going to ask too. That said, if we can add customized  E-commerce too, then
> we first need to get Business Development's approval. This usually takes
> time so I'd suggest we go without it at first, while we wait for the
> permission.

Confirmed. It requires BD approval + search provider agreement. If you really want to add it, it should go into a separate bug, and it's going to take a while.

> * Facebook: we don't add Facebook in the search plugins

We also don't add searchplugins that are not open without registration.

Comment 6

[bellayet]

Then include Google, bn.wikipedia, en.wikipedia, duckduckgo. Drop AjkerDeal for this time.

Comment 7

[Delphine Lebédel [:delphine - Use needinfo]]

We only include one wikipedia - in this case this should be the local one. I'll work on this patch now.

Comment 8

[Delphine Lebédel [:delphine - Use needinfo]]

(also, a heads-up we are contractually obliged to add Yahoo and Bing there too)

Comment 9

[Delphine Lebédel [:delphine - Use needinfo]]

Attachment: Bug 1365425 - [bn-BD] Add search engine setup for Firefox Mobile for Bengali (Bengladesh),

Review commit: https://reviewboard.mozilla.org/r/193694/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193694/

Comment 10

[Delphine Lebédel [:delphine - Use needinfo]]

Done - region.properties seems up to date so didn't change that. Waiting for review

Comment 11

[Francesco Lodolo [:flod]]

Comment on attachment 8922580 [details]
Bug 1365425 - [bn-BD] Add search engine setup for Firefox Mobile for Bengali (Bengladesh),

https://reviewboard.mozilla.org/r/193694/#review198904

::: mobile/locales/search/list.json:99
(Diff revision 1)
>        }
>      },
> +    "bn-BD": {
> +      "default": {
> +        "visibleDefaultEngines": [
> +          "google", "yahoo", "bing", "ddg", "wikipedia-bn"

I wonder if we should use yahoo-in instead of yahoo, but this is what we are usually doing on desktop, so let's stick to it for now.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76a50645f361
[bn-BD] Add search engine setup for Firefox Mobile for Bengali (Bengladesh), r=flod

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/76a50645f361

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/d3910b7628b8
[bn-BD] Add search engine setup for Firefox Mobile for Bengali (Bengladesh): Replace 'ddg' with 'duckduckgo' to fix bn-BD Fennec L10n nightly. r=nightly-fix a=nightly-fix

Comment 15

[Francesco Lodolo [:flod]]

(In reply to Pulsebot from comment #14)
> Pushed by [e-mail]:
> https://hg.mozilla.org/mozilla-central/rev/d3910b7628b8
> [bn-BD] Add search engine setup for Firefox Mobile for Bengali (Bengladesh):
> Replace 'ddg' with 'duckduckgo' to fix bn-BD Fennec L10n nightly.
> r=nightly-fix a=nightly-fix

Argh, sorry about this, and thanks for fixing it. I always double check searchplugins names, clearly I failed this time.

Comment 16

[Delphine Lebédel [:delphine - Use needinfo]]

Darn, I wrote it the way you do on browser, not mobile. Thanks for catching that! :)