1365428 - virtualenv.pp missing case for Darwin

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Amy Rich [:arr] [:arich]]

Puppet on the OS X taskcluster machines has been broken for a while now. There's no case for Darwin in virtualenv.pp. Now that we're netbooting the other 80 machines, we're seeing a bunch of failures:

Tue May 16 15:47:24 -0700 2017 Puppet (err): Could not retrieve catalog from remote server: Error 400 on SERVER: cannot install on Darwin at /etc/puppet/production/modules/packages/manifests/virtualenv.pp:24 on node t-yosemite-r7-460.test.releng.mdc1.mozilla.com
Tue May 16 15:47:24 -0700 2017 Puppet (err): Could not retrieve catalog; skipping run

Comment 1

[Wander Lairson Costa]

It feels like bug 1357753 was the cause of it. :dustin, can you give some guidance here?

Comment 2

[Dragos Crisan [:dragrom]]

Attachment: Bug_1365428_Fix_virtualenv_for_Darwin.patch

Comment 3

[Dragos Crisan [:dragrom]]

Attachment: Bug_1365428_Fix_virtualenv_for_Darwin.patch

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8868511 [details] [diff] [review]
Bug_1365428_Fix_virtualenv_for_Darwin.patch

Review of attachment 8868511 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good.  The py27_virtualenv DMG includes a symlink from /usr/local/bin/virtualenv so that should do the trick.

Please include a comment:
  # On Darwin we use the puppetagain Python exclusively, so defer
  # to its associated virtualenv

Comment 5

[Dragos Crisan [:dragrom]]

Comment on attachment 8868511 [details] [diff] [review]
Bug_1365428_Fix_virtualenv_for_Darwin.patch

https://hg.mozilla.org/build/puppet/rev/5eafa5ef5a66516711b8b17d13c90499c03b5c55