Closed Bug 1365431 Opened 5 years ago Closed 5 years ago

[el] Search engine setup for Firefox Mobile for Greek

Categories

(Mozilla Localizations :: el / Greek, enhancement)

enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: delphine, Assigned: delphine, NeedInfo)

References

()

Details

(Keywords: productization)

Attachments

(2 files)

We want to ship Firefox Mobile with a good list of search engines for Greek. Seems like the current list is 8 years old so it could use a refresh :) 

We're going to work towards this in three phases. First, the localization team and the l10n drivers will look at the market for the language and come up with a good set of search providers. Greek team, we'll need your input on this, the guidelines for making recommendations are on <https://developer.mozilla.org/en-US/docs/Productization_guide>. 

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:

> Google (mobile version), Yahoo, Bing, Amazon, Twitter, Wikipedia (slightly different to desktop, 32x32 icon)

We may also want to go with just a subset of the en-US engines, if that's more appropriate for the local market.

Once we decide to use a particular search engine (and we test it on a mobile device), l10n drivers will contact the owner and ask for permission in the cases where it's needed, and for specifics like proper search flags. Greem team, if this is needed we'll likely need your help to at least get the contact information.

For search engines that we already ship with on desktop and that you would like to include in mobile as well, the permission is not needed.  Consider using a mobile version of the engine if one is available.  Also, please make yourself familiar with instructions regarding the <Description/> element at <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions>. For mobile, we'll want 64x64 size images, too.

Once we have a specification on what the search engines for Spanish (Chile) should look like, Delphine and the localization team will work on an implementation on that. Delphine will create and attach patches for the desired changes and get them reviewed. After a successful review, :delphine will land them. Greek team, if you're interested, you could create the patches, too. You'd ask :delphine for review on those before landing. 

Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by Delphine or someone else appointed by the l10n drivers. The data here is sensitive to users and our search partners, thus the extra care here.

The Greek team and Delphine will be driving this bug to completion.
Fredy, Giorgos - any recommendations on what we should go with here please?
I see you currently have           
"google", "skroutz", "twitter", "wikipedia-el" 
should we keep those all?

We need to add yahoo there, but other than that, anything else missing?
Flags: needinfo?(giorgos.skafidas)
Flags: needinfo?(fredy)
(also bing mandatory now I believe)
Yes, these, "google", "yahoo", "bing", "skroutz", "twitter", "wikipedia-el" are ok.
Flags: needinfo?(fredy)
Assignee: nobody → lebedel.delphine
Attached patch bug1365431.patchSplinter Review
sources.properties update
Attachment #8871535 - Flags: review?(francesco.lodolo)
Comment on attachment 8871526 [details]
Bug 1365431 - [el] Search engine setup for Firefox Mobile for Greek,

https://reviewboard.mozilla.org/r/142996/#review146776

::: mobile/locales/search/list.json:78
(Diff revision 1)
>        }
>      },
>      "be": {
>        "default": {
>          "visibleDefaultEngines": [
> -          "google", "wikipedia-be", "bing", "yahoo", "yandex.by"
> +          "google",  "yahoo", "bing", "duckduckgo", "wikipedia-be", "yandex-by"

This change is not related to this bug and should be removed.
Comment on attachment 8871535 [details] [diff] [review]
bug1365431.patch

Review of attachment 8871535 [details] [diff] [review]:
-----------------------------------------------------------------

This one looks good.
Attachment #8871535 - Flags: review?(francesco.lodolo) → review+
@Mike
Are you fine with me reviewing these simpler patches, and CC you to these bugs, or you want to review all changes?
Flags: needinfo?(mozilla)
> Are you fine with me reviewing these simpler patches, and CC you to these bugs, or you want to review all changes?

Totally fine with you reviewing. You only need to bring me in for things that are related to search codes.
Flags: needinfo?(mozilla)
(In reply to Mike Kaply [:mkaply] from comment #9)
> > Are you fine with me reviewing these simpler patches, and CC you to these bugs, or you want to review all changes?
> 
> Totally fine with you reviewing. You only need to bring me in for things
> that are related to search codes.

Great, thanks for confirming.
Comment on attachment 8871526 [details]
Bug 1365431 - [el] Search engine setup for Firefox Mobile for Greek,

https://reviewboard.mozilla.org/r/142996/#review147022

Looks good now, thanks.

You can also commit the other one in the l10n repo at this point.
Attachment #8871526 - Flags: review?(francesco.lodolo) → review+
Pushed by francesco.lodolo@mozillaitalia.org:
https://hg.mozilla.org/integration/autoland/rev/f9170468d58b
[el] Search engine setup for Firefox Mobile for Greek, r=flod
https://hg.mozilla.org/mozilla-central/rev/f9170468d58b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.