Remove enablePrivilege calls in SafeBrowsing test case

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Safe Browsing
P3
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: tnguyen, Assigned: tnguyen)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
Follow bug 1365199, we should remove the calls in SafeBrowsing test cases
http://searchfox.org/mozilla-central/rev/9a7fbdee1d54f99cd548af95b81231d80e5f9ad1/toolkit/components/url-classifier/tests/mochitest/test_classifier.html#167
http://searchfox.org/mozilla-central/rev/9a7fbdee1d54f99cd548af95b81231d80e5f9ad1/toolkit/components/url-classifier/tests/mochitest/test_classifier_match.html#176
I added that due to "Permission denied to get property XPCComponents.classes" failures in tests.
Will run try again to see if we can remove these lines

Updated

8 months ago
Blocks: 1365199
(Assignee)

Updated

8 months ago
Blocks: 1365199
(Assignee)

Comment 2

8 months ago
Created attachment 8868357 [details] [diff] [review]
Remove enablePrivilege calls in SafeBrowsing test case

MozReview-Commit-ID: CedxaTfXFx0
(Assignee)

Updated

8 months ago
Assignee: nobody → tnguyen
(Assignee)

Updated

8 months ago
Status: NEW → ASSIGNED
Priority: -- → P3
(Assignee)

Comment 3

8 months ago
Comment on attachment 8868357 [details] [diff] [review]
Remove enablePrivilege calls in SafeBrowsing test case

Hi Henry, could you plz review this?
Thanks
Attachment #8868357 - Flags: review?(hchang)

Comment 4

8 months ago
Comment on attachment 8868357 [details] [diff] [review]
Remove enablePrivilege calls in SafeBrowsing test case

Review of attachment 8868357 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good except for an accidental removal. thanks :)

::: toolkit/components/url-classifier/tests/mochitest/test_classifier_match.html
@@ +182,5 @@
>        }).catch(function(e) {
>          ok(false, "Some tests failed with error " + e);
>          SimpleTest.finish();
>        });
>    });

Must be removed accidentally.
Attachment #8868357 - Flags: review?(hchang) → review+
(Assignee)

Comment 5

8 months ago
Ah, that's a redundant "script" tag, probably accidentally adding. That's found by eslint and removed it
Thanks you Henry

Comment 7

8 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/04e1c867ef45
Remove enablePrivilege calls in SafeBrowsing test case. r=hchang
Keywords: checkin-needed

Comment 8

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/04e1c867ef45
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.