1365476 - stylo: class handling during restyle hint computation may be suboptimal

Status: NEW

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Boris Zbarsky [:bzbarsky]]

In compute_hint (over in restyle_hints.rs) we do this:

  snapshot.each_class(|c| if !el.has_class(c) { additional_classes.push(c.clone()) });

The each_class call only does a single FFI call to get the list of classes in the snapshot.  But then for each one we do an FFI call that gets the class attr for the element, etc.  If we have multiple classes, this is a bunch more calls than we really need to do, I suspect.  It might be better to just get both lists once and then compare them directly without more FFI traffic.

Comment 1

[Chris Peterson [:cpeterson]]

status-firefox57=wontfix unless someone thinks this bug should block 57