Closed Bug 1365477 Opened 3 years ago Closed 3 years ago

configure linter doesn't check non-browser project moz.configures

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Per lint.py, it's supposed to iterate over different projects's moz.configure, but ends up only doing browser/moz.configure, skipping e.g. mobile/android/moz.configure.
Comment on attachment 8868369 [details]
Bug 1365477 - Use default=is_nightly instead of default=delayed_getattr(...).

https://reviewboard.mozilla.org/r/139946/#review144230
Attachment #8868369 - Flags: review?(cmanchester) → review+
Comment on attachment 8868370 [details]
Bug 1365477 - Ensure all callers of CommandLineHandler() pass a complete argv.

https://reviewboard.mozilla.org/r/139948/#review144232
Attachment #8868370 - Flags: review?(cmanchester) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/813c34daa4f9
Use default=is_nightly instead of default=delayed_getattr(...). r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/d2e6bfe37885
Ensure all callers of CommandLineHandler() pass a complete argv. r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/813c34daa4f9
https://hg.mozilla.org/mozilla-central/rev/d2e6bfe37885
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.