1365484 - Remove the call to AbstractThread::GetCurrent() in Benchmark.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

See bug 1365483 for the rationale.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1365484 - Remove the call to AbstractThread::GetCurrent() in Benchmark.cpp.

See bug 1365483 for the rationale.

Review commit: https://reviewboard.mozilla.org/r/139988/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139988/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8868398 [details]
Bug 1365484 - Remove the call to AbstractThread::GetCurrent() in Benchmark.cpp.

https://reviewboard.mozilla.org/r/139988/#review143334

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4887aee47d0a
Remove the call to AbstractThread::GetCurrent() in Benchmark.cpp. r=gerald

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4887aee47d0a

Comment 6

[Jean-Yves Avenard [:jya]]

Oh. Dispatching on the main thread here wasn't a great idea I'm afraid. 

Though, I don't fully recall the details nor what the original thread was supposed to be. 
This is called to test if our machine is fast enough. It's done by decoding a VP9 video. It can be very taxing from a CPU perspective. 

Running this on the main thread could cause severe UI impact. .

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/9a7fbdee1d54f99cd548af95b81231d80e5f9ad1/dom/media/Benchmark.cpp#54
It is called from VP9Benchmark::IsVP9DecodeFast() which happens on the main thread. So the patch doesn't really make a difference.