Closed
Bug 1365505
Opened 8 years ago
Closed 7 years ago
[Fennec][HLS] Turn on HLS native support not only for Nightly
Categories
(Firefox for Android Graveyard :: Audio/Video, defect)
Firefox for Android Graveyard
Audio/Video
Tracking
(relnote-firefox 59+, firefox56 wontfix, firefox57 wontfix, firefox59 fixed)
RESOLVED
FIXED
Firefox 59
People
(Reporter: JamesCheng, Assigned: kikuo)
References
(Depends on 3 open bugs)
Details
Attachments
(2 files, 2 obsolete files)
We intend to enable HLS support only for nightly.
Three parts need to take care(should remove the '''nightly only''' flag in the future)
1.
Bug 1341990 - Part 0: Add a feature flag to control source code build time coverage for ExoPlayer.
2.
Bug 1350246 - [Part7] Define MOZ_ANDROID_HLS_SUPPORT macro and add the native code into source tree.
3.
Bug 1350246 - [Part4] Add a feature preference for HLS, default on for Fennec.
Reporter | ||
Updated•8 years ago
|
Summary: Turn on HLS native support not only for Nightly → [Fennec][HLS] Turn on HLS native support not only for Nightly
Reporter | ||
Comment 1•7 years ago
|
||
AppConstants.NIGHTLY_BUILD || AppConstants.DEBUG_BUILD should remove AppConstants.NIGHTLY_BUILD when we support HLS not only on Nightly build.
Assignee | ||
Comment 2•7 years ago
|
||
According to the SV's pre-beta sign-off report.
I think we could let this feature ride on FX 56, is that ok ?
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(bwu)
Flags: needinfo?(bchien)
Resolution: --- → FIXED
Assignee | ||
Updated•7 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 3•7 years ago
|
||
To comment 2, Yes. Attached Pre-Beta Sign-off.
[Fennec] Make Gecko native support HLS on Fennec
Feature sign off report, Manual QA
Targeted GA: Firefox 56 - September 26, 2017
Sign off phase: Pre-Beta (Fx56).
Manual QA'S ASSESSMENT & RECOMMENDATION
Feature status:GREEN
Reason: There are no blocking issues nor crashes, but there are still some bugs open .
Proposed course of action: let this feature ride FX56 and fix open bugs during the beta cycle.
MANUAL TESTING SUMMARY
Testing status: COMPLETED (100%)
20 passed (83%), 0 blocked (0%), 4 failed with known bugs (17%), 0 failed with new bugs (0%)
Test report: on TestRail
New bugs uncovered during sign off: None
Known bugs encountered during sign off:
1377873, 1377891
Flags: needinfo?(bchien)
Updated•7 years ago
|
Assignee: nobody → jacheng
Comment 4•7 years ago
|
||
(In reply to Kilik Kuo [:kikuo] from comment #2)
> According to the SV's pre-beta sign-off report.
>
> I think we could let this feature ride on FX 56, is that ok ?
Good job! Let's ship it!
Please create a patch to turn on it.
Flags: needinfo?(bwu)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Reporter | ||
Comment 7•7 years ago
|
||
Please see the patch for turning on this feature.
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8892381 [details]
Bug 1365505 - Part2-Turn on the pref for hls not only on nightly.
https://reviewboard.mozilla.org/r/163336/#review168716
Ship it!
Attachment #8892381 -
Flags: review?(bwu) → review+
Assignee | ||
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8892380 [details]
Bug 1365505 - Part1-Make the feature flag be exposed not only on nightly.
https://reviewboard.mozilla.org/r/163334/#review168758
Attachment #8892380 -
Flags: review?(kikuo) → review+
Comment 10•7 years ago
|
||
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: repository is read only
remote: Repo closed per glandium's request; sheriff not around to mark it closed, so deploying the read-only hammer.
remote: refusing to add changesets
remote: prechangegroup.readonly hook failed
abort: push failed on remote
Comment 11•7 years ago
|
||
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5210a2cb19a
Part1-Make the feature flag be exposed not only on nightly. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/80491c51a8e7
Part2-Turn on the pref for hls not only on nightly. r=bwu
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d5210a2cb19a
https://hg.mozilla.org/mozilla-central/rev/80491c51a8e7
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Reporter | ||
Comment 13•7 years ago
|
||
Comment on attachment 8892380 [details]
Bug 1365505 - Part1-Make the feature flag be exposed not only on nightly.
Approval Request Comment
[Feature/Bug causing the regression]:Feature bug 1345752 for HLS playback on Fennec
[User impact if declined]: Cannot play video using HLS
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: SV has already tested and signed off.
[List of other uplifts needed for the feature/fix]: Part2 https://reviewboard.mozilla.org/r/163336/diff/1#index_header
[Is the change risky?]: na
[Why is the change risky/not risky?]: has already been tested through Nightly.
[String changes made/needed]: na
Attachment #8892380 -
Flags: approval-mozilla-beta?
Updated•7 years ago
|
status-firefox56:
--- → affected
Flags: needinfo?(lhenry)
Comment 15•7 years ago
|
||
Comment on attachment 8892380 [details]
Bug 1365505 - Part1-Make the feature flag be exposed not only on nightly.
Has QE signoff, let's uplift for 56 beta 1.
Attachment #8892380 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 16•7 years ago
|
||
Comment on attachment 8892381 [details]
Bug 1365505 - Part2-Turn on the pref for hls not only on nightly.
[Triage Comment]
Attachment #8892381 -
Flags: approval-mozilla-beta+
Comment 17•7 years ago
|
||
bugherder uplift |
Comment 18•7 years ago
|
||
This was backed out from 56 and 57 due to bug 1389990.
https://hg.mozilla.org/mozilla-central/rev/b5fa1d07ad05
https://hg.mozilla.org/mozilla-central/rev/3bf1126bddd8
https://hg.mozilla.org/releases/mozilla-beta/rev/f53fa9ca89b9
https://hg.mozilla.org/releases/mozilla-beta/rev/dc22f5250239
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Firefox 57 → ---
Updated•7 years ago
|
Status: REOPENED → ASSIGNED
Updated•7 years ago
|
Depends on: gradle-automation, 1286677
Comment 19•7 years ago
|
||
Release Note Request (optional, but appreciated)
[Why is this notable]: It has been disabled in 56, so the release note should be removed from https://www.mozilla.org/en-US/firefox/android/56.0beta/releasenotes/.
[Affects Firefox for Android]: Yes, only Firefox for Android
relnote-firefox:
--- → ?
Updated•7 years ago
|
No longer depends on: gradle-automation
Updated•7 years ago
|
Depends on: gradle-automation-v2
Comment 20•7 years ago
|
||
James, I learned from Max that even there are some minor remaining work about Gradle, it's now ready for you to bring HLS back since Fennec 59. Please go ahead and you may consult Max shall you have any question about the setup w/ Gradle. Thanks.
Flags: needinfo?(jacheng)
Reporter | ||
Comment 21•7 years ago
|
||
Thanks, I replied in Bug 1389990 comment 29
Flags: needinfo?(jacheng)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8892380 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8892381 -
Attachment is obsolete: true
Comment 23•7 years ago
|
||
mozreview-review |
Comment on attachment 8930872 [details]
Bug 1365505 - [P1][Fennec] Enable HLS support by default for all brandings.
https://reviewboard.mozilla.org/r/201972/#review207646
Attachment #8930872 -
Flags: review?(jolin) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 26•7 years ago
|
||
mozreview-review |
Comment on attachment 8933242 [details]
Bug 1365505 - [P2][Fennec] Only include exoplayer & HLSDecoder related components when building --with-gradle.
https://reviewboard.mozilla.org/r/204180/#review209712
Per Bug 1389990 Comment 42, I disable hls when building fennec without gradle.
Comment 27•7 years ago
|
||
mozreview-review |
Comment on attachment 8933242 [details]
Bug 1365505 - [P2][Fennec] Only include exoplayer & HLSDecoder related components when building --with-gradle.
https://reviewboard.mozilla.org/r/204180/#review210034
Attachment #8933242 -
Flags: review?(max) → review+
Assignee | ||
Comment 28•7 years ago
|
||
Try run - https://treeherder.mozilla.org/#/jobs?repo=try&revision=f233974b4a5e
Try run for (Bng) - https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac54f0149b56
Looks good.
Assignee | ||
Updated•7 years ago
|
Assignee: jacheng → kikuo
Comment 29•7 years ago
|
||
Pushed by kikuo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9545b9df0c6d
[P1][Fennec] Enable HLS support by default for all brandings. r=jolin
https://hg.mozilla.org/integration/autoland/rev/ce2c43ec79ae
[P2][Fennec] Only include exoplayer & HLSDecoder related components when building --with-gradle. r=maliu
Comment 30•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9545b9df0c6d
https://hg.mozilla.org/mozilla-central/rev/ce2c43ec79ae
Status: ASSIGNED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Comment 31•7 years ago
|
||
This was in the 56 beta notes as "Improved support for HLS (HTTP Live Streaming) playback".
For now, I will add the same note back in for 59.0b1.
What do you think? Is there anything more specific that you'd like to be in the note?
Flags: needinfo?(wehuang)
Comment 32•7 years ago
|
||
Thanks for the reminder, Liz! Yes the support was re-enabled in 59 Nightly and got pre-beta sign-off on Dec. 20, so should be included in the 59 release note instead, and I think the existing description holds well. Once the release note is public for comment I'll also ping media team and PM to see if they would like to refine anything specific.
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #31)
> This was in the 56 beta notes as "Improved support for HLS (HTTP Live
> Streaming) playback".
>
> For now, I will add the same note back in for 59.0b1.
> What do you think? Is there anything more specific that you'd like to be in
> the note?
Flags: needinfo?(wehuang)
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•