Closed
Bug 1365515
Opened 7 years ago
Closed 7 years ago
Remove tick_context_t
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(2 files)
|
4.24 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
|
8.60 KB,
patch
|
jseward
:
review+
|
Details | Diff | Splinter Review |
A profiler cleanup.
|
Assignee | |
Comment 1•7 years ago
|
||
It's now either tier 3 or unsupported, I'm not sure which.
Attachment #8868426 -
Flags: review?(mstange)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•7 years ago
|
||
On platforms using EHABI or LUL unwinding we need to record a ucontext_t in TickSample. But in others we don't. This patch makes this clearer, resulting in the following benefits. - We don't need TickSample::mContext on Windows. - PopulateContext() doesn't need the aContext argument on some platforms. - We don't need the tick_context_t typedef. - We avoid some casts.
Attachment #8868427 -
Flags: review?(jseward)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8868427 [details] [diff] [review] (part 2) - Remove tick_context_t Review of attachment 8868427 [details] [diff] [review]: ----------------------------------------------------------------- Looks OK to me.
Attachment #8868427 -
Flags: review?(jseward) → review+
|
||
Updated•7 years ago
|
Attachment #8868426 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ba879bb0961978845bc2c4d30043e44ee0200ae Bug 1365515 (part 1) - Remove profiler support for x86/Darwin. r=mstange. https://hg.mozilla.org/integration/mozilla-inbound/rev/368f63c34bad52d96902b2e8c87b0bfea33d5dfd Bug 1365515 (part 2) - Remove tick_context_t. r=jseward.
|
||
Comment 5•7 years ago
|
||
Sorry had to back this out for merge conflict in tools/profiler/core/platform-win32.cpp & tools/profiler/core/platform.cpp, please help to reland it. Thank you.
Flags: needinfo?(n.nethercote)
Backout by ihsiao@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f22235120e9f Backed out changeset 368f63c34bad for merge conflict https://hg.mozilla.org/integration/mozilla-inbound/rev/e61af009b471 Backed out changeset 7ba879bb0961 for merge conflict
|
|
Assignee | |
Comment 7•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9879b590c4b8638029765eee57481ff78703e01 Bug 1365515 (part 1, attempt 2) - Remove profiler support for x86/Darwin. r=mstange. https://hg.mozilla.org/integration/mozilla-inbound/rev/05c1b54b031923a351d6a1d1903a3b8172860f3d Bug 1365515 (part 2, attempt 2) - Remove tick_context_t. r=jseward.
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d9879b590c4b https://hg.mozilla.org/mozilla-central/rev/05c1b54b0319
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(n.nethercote)
You need to log in
before you can comment on or make changes to this bug.
Description
•