Closed Bug 1365515 Opened 5 years ago Closed 5 years ago

Remove tick_context_t

Categories

(Core :: Gecko Profiler, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(2 files)

A profiler cleanup.
It's now either tier 3 or unsupported, I'm not sure which.
Attachment #8868426 - Flags: review?(mstange)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
On platforms using EHABI or LUL unwinding we need to record a ucontext_t in
TickSample. But in others we don't.

This patch makes this clearer, resulting in the following benefits.

- We don't need TickSample::mContext on Windows.

- PopulateContext() doesn't need the aContext argument on some platforms.

- We don't need the tick_context_t typedef.

- We avoid some casts.
Attachment #8868427 - Flags: review?(jseward)
Comment on attachment 8868427 [details] [diff] [review]
(part 2) - Remove tick_context_t

Review of attachment 8868427 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK to me.
Attachment #8868427 - Flags: review?(jseward) → review+
Attachment #8868426 - Flags: review?(mstange) → review+
Sorry had to back this out for merge conflict in tools/profiler/core/platform-win32.cpp & tools/profiler/core/platform.cpp, please help to reland it. Thank you.
Flags: needinfo?(n.nethercote)
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f22235120e9f
Backed out changeset 368f63c34bad for merge conflict
https://hg.mozilla.org/integration/mozilla-inbound/rev/e61af009b471
Backed out changeset 7ba879bb0961 for merge conflict
https://hg.mozilla.org/mozilla-central/rev/d9879b590c4b
https://hg.mozilla.org/mozilla-central/rev/05c1b54b0319
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Flags: needinfo?(n.nethercote)
You need to log in before you can comment on or make changes to this bug.