Closed
Bug 1365516
Opened 4 years ago
Closed 4 years ago
Remove the call to AbstractThread::GetCurrent() in WebRenderImageLayer.cpp
Categories
(Core :: Graphics: WebRender, enhancement, P2)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
(Blocks 1 open bug)
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
See bug 1365483 for the rationale.
Assignee | ||
Comment 1•4 years ago
|
||
http://searchfox.org/mozilla-central/rev/9a7fbdee1d54f99cd548af95b81231d80e5f9ad1/gfx/layers/wr/WebRenderImageLayer.cpp#108-109 Hi Sotaro, Which thread does WebRenderImageLayer::RenderLayer() run in? Is it possible to replace AbstractThread::GetCurrent() with an explicitly specified AbstractThread like AbstractThread::MainThread()?
Blocks: 1365483
Flags: needinfo?(sotaro.ikeda.g)
Comment 2•4 years ago
|
||
(In reply to JW Wang [:jwwang] [:jw_wang] from comment #1) > http://searchfox.org/mozilla-central/rev/ > 9a7fbdee1d54f99cd548af95b81231d80e5f9ad1/gfx/layers/wr/WebRenderImageLayer. > cpp#108-109 > > Hi Sotaro, > Which thread does WebRenderImageLayer::RenderLayer() run in? Is it possible > to replace AbstractThread::GetCurrent() with an explicitly specified > AbstractThread like AbstractThread::MainThread()? It always run on main thread. Yes, we could use AbstractThread::MainThread() here.
Flags: needinfo?(sotaro.ikeda.g)
Updated•4 years ago
|
Priority: -- → P2
Whiteboard: [gfx-noted]
Comment hidden (mozreview-request) |
Assignee | ||
Updated•4 years ago
|
Attachment #8868890 -
Flags: review?(sotaro.ikeda.g)
Comment 4•4 years ago
|
||
mozreview-review |
Comment on attachment 8868890 [details] Bug 1365516 - Remove the call to AbstractThread::GetCurrent() in WebRenderImageLayer.cpp. https://reviewboard.mozilla.org/r/140514/#review143918
Attachment #8868890 -
Flags: review?(sotaro.ikeda.g) → review+
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f7df9502735 Remove the call to AbstractThread::GetCurrent() in WebRenderImageLayer.cpp. r=sotaro
Comment 7•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0f7df9502735
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•