Closed Bug 1365524 Opened 3 years ago Closed 3 years ago

Make MetadataHolder non-ref-counted

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(2 files)

Since MozPromise supports move-only types, we don't need to make MetadataHolder a ref-counted type.
Attachment #8868881 - Flags: review?(jyavenard)
Assignee: nobody → jwwang
Priority: -- → P3
Comment on attachment 8868881 [details]
Bug 1365524. P1 - Make MetadataHolder non-ref-counted.

https://reviewboard.mozilla.org/r/140494/#review143946

please split this patch in two...

::: dom/media/MediaDecoder.h:575
(Diff revision 1)
>  private:
>    nsCString GetDebugInfo();
>  
>    // Called when the metadata from the media file has been loaded by the
>    // state machine. Call on the main thread only.
> -  void MetadataLoaded(nsAutoPtr<MediaInfo> aInfo,
> +  void MetadataLoaded(UniquePtr<MediaInfo> aInfo,

those changes from AutoPtr to UniquePtr should be made in another patch. this is out of scope and different to the commit comment
Attachment #8868881 - Flags: review?(jyavenard) → review+
Comment on attachment 8868917 [details]
Bug 1365524. P2 - replace use of nsAutoPtr with UniquePtr.

https://reviewboard.mozilla.org/r/140566/#review144098
Attachment #8868917 - Flags: review?(jyavenard) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/667977b393b6
P1 - Make MetadataHolder non-ref-counted. r=jya
https://hg.mozilla.org/integration/autoland/rev/cf1159d4b489
P2 - replace use of nsAutoPtr with UniquePtr. r=jya
https://hg.mozilla.org/mozilla-central/rev/667977b393b6
https://hg.mozilla.org/mozilla-central/rev/cf1159d4b489
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.