Closed Bug 1365538 Opened 3 years ago Closed 3 years ago

Prioritize reads in FileBlockCache

Categories

(Core :: Audio/Video: Playback, enhancement)

55 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

Details

Attachments

(2 files)

While writes to the FileBlockCache are quickly stored in memory to be dealt in a separate thread, reads are blocking the caller until all data has been read from memory or file.

We should try to prioritize reads, so that they don't clog their thread for too long.
Comment on attachment 8868473 [details]
Bug 1365538 - Use Mutex instead of Monitor in FileBlockCache -

https://reviewboard.mozilla.org/r/140086/#review143726
Attachment #8868473 - Flags: review?(cpearce) → review+
Comment on attachment 8868474 [details]
Bug 1365538 - Postpone FileBlockCache writes while reading -

https://reviewboard.mozilla.org/r/140088/#review143728
Attachment #8868474 - Flags: review?(cpearce) → review+
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/461b3e0c577f
Use Mutex instead of Monitor in FileBlockCache - r=cpearce
https://hg.mozilla.org/integration/autoland/rev/442e51c75171
Postpone FileBlockCache writes while reading - r=cpearce
https://hg.mozilla.org/mozilla-central/rev/461b3e0c577f
https://hg.mozilla.org/mozilla-central/rev/442e51c75171
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.