Closed
Bug 1365553
Opened 8 years ago
Closed 8 years ago
The user gets disconnected from sync when updating from 7.x to 8.x
Categories
(Firefox for iOS :: Firefox Accounts, defect, P1)
Tracking
()
VERIFIED
FIXED
People
(Reporter: csuciu, Assigned: st3fan)
Details
(Keywords: reproducible, Whiteboard: [MobileCore])
Attachments
(4 files)
1. Install 7.3b2756 (last 7.x Beta build available in TF).
2. Sign into Sync.
3. Update to 8.0b6.
4. Check Firefox settings.
Result: The FxA is signed out.
This issue is not reproducible on update from 7.3(2756) to 7.5(3349).
Comment 1•8 years ago
|
||
Marking as P1/Critical for v8.0 since this is pretty bad!
Assignee | ||
Comment 2•8 years ago
|
||
Keychain group?
Updated•8 years ago
|
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
Comment 3•8 years ago
|
||
Reproducible via install-over 7.0bx to latest green FirefoxBeta scheme build on BuddyBuild
Keywords: reproducible
Comment 4•8 years ago
|
||
Could you retest this upgrade path using 8.0b3455 instead of b6?
Flags: needinfo?(catalin.suciu)
Reporter | ||
Comment 5•8 years ago
|
||
Just updated from 7.3b2756 to 8.0b3455 and the issue is still reproducible.
Flags: needinfo?(catalin.suciu)
Comment 6•8 years ago
|
||
The difficult thing with reproducing this is the app groups and provisions has changed between v7.x and v8.x. By default, FirefoxBeta builds on the v7.x branch were enterprise builds on BB but the builds now on v8.x are non-enterprise.
Unfortunately I'm unable to test the upgrade scenario as my TestFlight is saying it's unavailable for downloads.
I'd like to give the upgrade scenario a try with a v8.x build that has been resigned the same way we did for the v7.x builds and see if this issue occurs. This would at least narrow it down to a app groups issue or not. I'd be surprised if this happens after we try upgrading since the app group hasn't changed.
Assignee | ||
Updated•8 years ago
|
Whiteboard: [MobileCore] → [MobileCore][b3]
Assignee | ||
Comment 7•8 years ago
|
||
This needs to be tested with a realistic scenario:
- install 7.5 from app store
- install 8.0 Release internal testflight build on top
I need to give this some thought. We can do an 8.0 internal testflight beta on the release channel, but i am not sure if that closes the door for a 7.6 release.
Needinfo'd myself.
Flags: needinfo?(sarentz)
Updated•8 years ago
|
Assignee: sleroux → nobody
Status: ASSIGNED → NEW
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(sarentz)
Whiteboard: [MobileCore][b3] → [MobileCore]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → sarentz
Assignee | ||
Comment 8•8 years ago
|
||
I can confirm that this happens:
- Installed 7.3 Beta from TestFlight
- Logged in, created some history, etc.
- Upgraded to 8.0 Beta via TestFlight
Expected: you are still logged in.
Actual: Logged out of Sync.
The good news is that:
- All my data is still there
- When I hit "Sign In to Firefox", it knows my account and only asks for my password.
- Signing in works, sync works after that.
Is this expected behaviour? I doubt it, but we should check the code if this is enforced?
Is there something in the Keychain that gets lost?
Assignee | ||
Comment 9•8 years ago
|
||
Sync log - after installing 8.0
Assignee | ||
Comment 10•8 years ago
|
||
Browser log - after installing 8.0
Assignee | ||
Comment 11•8 years ago
|
||
I have a pretty reliable setup now where I can build and install 7.5 on an iPod touch and then build and install 8.0 on top of it. It shows the same behaviour as written in comment 8.
There is not a lot interesting in the attached logs. We will have to add more debug logging to the application to find out why it decides to log out of FxA.
Assignee | ||
Comment 12•8 years ago
|
||
Keychain log - I don't think this shows anything from after the upgrade - the timestamps don't match.
Assignee | ||
Comment 13•8 years ago
|
||
I think the root cause here is that FirefoxAccount.AccountSchemaVersion has been increment. And there is no migration path in FirefoxAccount.fromDictionary(). It just fails and returns nil.
Assignee | ||
Updated•8 years ago
|
Summary: The user gets disconnected from sync when updating from 7.3b2756 to 8.0b6 → The user gets disconnected from sync when updating from 7.x to 8.x
Assignee | ||
Comment 14•8 years ago
|
||
This patch allows a v1 *AccountSchema* to populate a v2 install.
```
// As of this writing, the current version, v2, is backward compatible with v1. The only
// field added is pushRegistration, which is ok to be nil. If it is nil, then the app
// will attempt registration when it starts up.
```
This will let clients upgrade from *v7.x* to *v8.x* without losing their FxA login.
Attachment #8883699 -
Flags: review?(jhugman)
Assignee | ||
Updated•8 years ago
|
Whiteboard: [MobileCore] → [MobileCore][needsuplift]
Updated•8 years ago
|
Attachment #8883699 -
Flags: review?(jhugman) → review+
Assignee | ||
Comment 15•8 years ago
|
||
Landed and uplifted to v8.x
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [MobileCore][needsuplift] → [MobileCore]
Reporter | ||
Comment 16•8 years ago
|
||
Updated from 7.3b2756 to 8.0b4393 and the bug is no longer reproducible.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•