Closed
Bug 1365554
Opened 7 years ago
Closed 7 years ago
Storage inspector related failures in browser_devtools_api.js `type listStores failed`
Categories
(DevTools :: Storage Inspector, enhancement, P2)
DevTools
Storage Inspector
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jdescottes, Assigned: miker)
Details
(Whiteboard: [todo-mr])
Attachments
(2 files)
Now that the storage inspector is enabled by default, it gets selected in the mochitest browser_devtools_api.js right before we destroy the toolbox and finish the test. This does not make the test fail, but I think it's something that should be investigated anyway. Note that waiting before destroying the toolbox makes the error go away. STRs: - run the test devtools/client/framework/test/browser_devtools_api.js ER: no errors in the logs AR: error `Message: Error: Connection closed, pending request to server1.conn0.child1/storageActor10, type listStores failed`
Reporter | ||
Comment 1•7 years ago
|
||
Added the full stack trace in attachment 8868486 [details]
Reporter | ||
Comment 2•7 years ago
|
||
It looks like it's simply this code that calls console.error:
> this.front.listStores().then(storageTypes => {
> this.populateStorageTree(storageTypes);
> }).then(null, console.error);
So this is probably harmless. FWIW, in the inspector, we usually use a promise catch which will log a warning if the promise failed after the inspector was destroyed, but will log an error in any other case.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → mratcliffe
Priority: -- → P2
Whiteboard: [todo-mr]
Comment hidden (mozreview-request) |
Reporter | ||
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8874013 [details] Bug 1365554 - Fix storage inspector failures in browser_devtools_api.js https://reviewboard.mozilla.org/r/145460/#review149398 Looks good, thanks for the fix Mike!
Attachment #8874013 -
Flags: review?(jdescottes) → review+
Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2c0e0f3062ae Fix storage inspector failures in browser_devtools_api.js r=jdescottes
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2c0e0f3062ae
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•