1365554 - Storage inspector related failures in browser_devtools_api.js `type listStores failed`

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, enhancement, P2)

Description

[Julian Descottes [:jdescottes]]

Attachment: stack_trace.txt

Now that the storage inspector is enabled by default, it gets selected in the mochitest browser_devtools_api.js right before we destroy the toolbox and finish the test.

This does not make the test fail, but I think it's something that should be investigated anyway. Note that waiting before destroying the toolbox makes the error go away.

STRs:
- run the test devtools/client/framework/test/browser_devtools_api.js

ER: no errors in the logs
AR: error `Message: Error: Connection closed, pending request to server1.conn0.child1/storageActor10, type listStores failed`

Comment 1

[Julian Descottes [:jdescottes]]

Added the full stack trace in attachment 8868486 [details]

Comment 2

[Julian Descottes [:jdescottes]]

It looks like it's simply this code that calls console.error:

>  this.front.listStores().then(storageTypes => {
>    this.populateStorageTree(storageTypes);
>  }).then(null, console.error);

So this is probably harmless. FWIW, in the inspector, we usually use a promise catch which will log a warning if the promise failed after the inspector was destroyed, but will log an error in any other case.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1365554 - Fix storage inspector failures in browser_devtools_api.js

The changes to devtools/client/framework/test/browser_devtools_api.js are purely eslint fixes so you only need to glance over them.

The changes to ui.js checks if the toolbox is being destroyed... if it is we don't log an error, otherwise we do.

Review commit: https://reviewboard.mozilla.org/r/145460/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145460/

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8874013 [details]
Bug 1365554 - Fix storage inspector failures in browser_devtools_api.js

https://reviewboard.mozilla.org/r/145460/#review149398

Looks good, thanks for the fix Mike!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c0e0f3062ae
Fix storage inspector failures in browser_devtools_api.js r=jdescottes

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2c0e0f3062ae