Remove unused social.sidebar.unload_timeout_ms pref

VERIFIED FIXED in Firefox 55

Status

()

Firefox
General
VERIFIED FIXED
5 months ago
4 months ago

People

(Reporter: dao, Assigned: janx, Mentored)

Tracking

({good-first-bug})

Trunk
Firefox 55
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox55 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 months ago
This pref doesn't seem to be used:

http://searchfox.org/mozilla-central/rev/9a7fbdee1d54f99cd548af95b81231d80e5f9ad1/browser/app/profile/firefox.js#1275

We should remove it.
(Assignee)

Comment 1

5 months ago
Created attachment 8869093 [details] [diff] [review]
Remove unused pref.
Attachment #8869093 - Flags: review?(dao+bmo)
(Reporter)

Comment 2

5 months ago
Comment on attachment 8869093 [details] [diff] [review]
Remove unused pref.

Thanks :)
Attachment #8869093 - Flags: review?(dao+bmo) → review+
(Reporter)

Updated

5 months ago
Assignee: nobody → janx

Comment 3

5 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c2648fe57b8
Remove unused pref. r=dao
(Assignee)

Comment 4

5 months ago
Thank you for the very quick review! I took this good first bug to show off janitor.technology during an event at Mozilla Paris :)

For posterity, it seems this pref was introduced for the "social sidebar" in commit [0] (from 2012). The social sidebar feature was later removed by commit [1] (in 2016), but the pref was left over.

[0] Bug 802435 - https://github.com/mozilla/gecko-dev/commit/45284bf0c54927739baaa8c8212c1fddf67bfa37
[1] Bug 1289549 - https://github.com/mozilla/gecko-dev/commit/4987c70c34e87aa89c65f75cbdeb01ca7373f76e

Comment 5

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3c2648fe57b8
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Comment 6

5 months ago
I have reproduced this bug with Nightly 55.0a1 (2017-05-17)   on Ubuntu 16.04, 64 bit!

The fix is now verified on Latest Nightly.

Build ID 	20170601100220
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170531]

Comment 7

4 months ago
I have successfully reproduce this bug with Nightly 55.0a1 (2017-05-17) (32-bit) on windows 10 (32 bit)

this bug is verified fix with latest beta 55.0b3 (32-bit)

Build ID:  20170619071723
Mozilla/5.0 (Windows NT 10.0; rv:55.0) Gecko/20100101 Firefox/55.0
QA Whiteboard: [bugday-20170621]

Comment 8

4 months ago
As per Comment 6 and Comment 7, I am marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.