Closed Bug 1365559 Opened 3 years ago Closed 3 years ago
Remove unused social
.sidebar .unload _timeout _ms pref
This pref doesn't seem to be used: http://searchfox.org/mozilla-central/rev/9a7fbdee1d54f99cd548af95b81231d80e5f9ad1/browser/app/profile/firefox.js#1275 We should remove it.
Comment on attachment 8869093 [details] [diff] [review] Remove unused pref. Thanks :)
Attachment #8869093 - Flags: review?(dao+bmo) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/3c2648fe57b8 Remove unused pref. r=dao
Thank you for the very quick review! I took this good first bug to show off janitor.technology during an event at Mozilla Paris :) For posterity, it seems this pref was introduced for the "social sidebar" in commit  (from 2012). The social sidebar feature was later removed by commit  (in 2016), but the pref was left over.  Bug 802435 - https://github.com/mozilla/gecko-dev/commit/45284bf0c54927739baaa8c8212c1fddf67bfa37  Bug 1289549 - https://github.com/mozilla/gecko-dev/commit/4987c70c34e87aa89c65f75cbdeb01ca7373f76e
I have reproduced this bug with Nightly 55.0a1 (2017-05-17) on Ubuntu 16.04, 64 bit! The fix is now verified on Latest Nightly. Build ID 20170601100220 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 [bugday-20170531]
I have successfully reproduce this bug with Nightly 55.0a1 (2017-05-17) (32-bit) on windows 10 (32 bit) this bug is verified fix with latest beta 55.0b3 (32-bit) Build ID: 20170619071723 Mozilla/5.0 (Windows NT 10.0; rv:55.0) Gecko/20100101 Firefox/55.0
QA Whiteboard: [bugday-20170621]
You need to log in before you can comment on or make changes to this bug.