option -rpath-link is not supported by Solaris linker

RESOLVED FIXED in Firefox 55

Status

Firefox Build System
General
RESOLVED FIXED
a year ago
3 months ago

People

(Reporter: Petr Sumbera, Assigned: Petr Sumbera)

Tracking

45 Branch
mozilla55

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
User Agent: Mozilla/5.0 (X11; SunOS i86pc; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20170420232850

Steps to reproduce:

old-configure.in and js/src/old-configure.in set as default:
MOZ_FIX_LINK_PATHS="-Wl,-rpath-link,${DIST}/bin -Wl,-rpath-link,${prefix}/lib"

but Solaris linker doesn't support -rpath-link and it just skip it. Which gives:

-Wl,${DIST}/bin -Wl,${prefix}/lib

which is just wrong.

So for Solairs we should just set MOZ_FIX_LINK_PATHS to nothing.
(Assignee)

Comment 1

a year ago
Created attachment 8868603 [details] [diff] [review]
Bug1365620.patch
Attachment #8868603 - Flags: review?(mh+mozilla)
Component: Untriaged → Build Config
Product: Firefox → Core
Attachment #8868603 - Flags: review?(mh+mozilla) → review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed
Assignee: nobody → petr.sumbera

Comment 2

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/741c96bf7418
Option -rpath-link is not supported by Solaris linker. r=glandium
Keywords: checkin-needed

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/741c96bf7418
Status: UNCONFIRMED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.