Closed Bug 1365620 Opened 3 years ago Closed 3 years ago

option -rpath-link is not supported by Solaris linker

Categories

(Firefox Build System :: General, defect)

45 Branch
defect
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: petr.sumbera, Assigned: petr.sumbera)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; SunOS i86pc; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20170420232850

Steps to reproduce:

old-configure.in and js/src/old-configure.in set as default:
MOZ_FIX_LINK_PATHS="-Wl,-rpath-link,${DIST}/bin -Wl,-rpath-link,${prefix}/lib"

but Solaris linker doesn't support -rpath-link and it just skip it. Which gives:

-Wl,${DIST}/bin -Wl,${prefix}/lib

which is just wrong.

So for Solairs we should just set MOZ_FIX_LINK_PATHS to nothing.
Attached patch Bug1365620.patchSplinter Review
Attachment #8868603 - Flags: review?(mh+mozilla)
Component: Untriaged → Build Config
Product: Firefox → Core
Attachment #8868603 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
Assignee: nobody → petr.sumbera
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/741c96bf7418
Option -rpath-link is not supported by Solaris linker. r=glandium
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/741c96bf7418
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.