1365627 - Synced Tabs sidebar search box has degraded

Status: RESOLVED WORKSFORME

(Firefox :: Sync, defect)

Description

[Ryan Feeley [:rfeeley]]

Attachment: sidebar.png

STEPS TO REPRODUCE
1. Sync at least two devices and have open tabs
2. Open Synced Tabs sidebar (HTML based, not XUL)

EXPECTED RESULTS
Search box looks like Bookmarks and History search box

ACTUAL RESULTS
Looks wrong in every state

Comment 1

[:Gijs (he/him)]

You wrote this broke weeks ago. Any chance you can determine when it broke using mozregression? ( https://mozilla.github.io/mozregression/ )

Comment 2

[Ryan Feeley [:rfeeley]]

Attachment: Screenshot 2017-04-24 16.54.46.png

I'm not sure how to run that tool, but I first spotted it 2017-04-24.

Comment 3

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
This is most bad on OS X, and reproduces on beta 54. On Windows there are no borders at all, which at least doesn't look patently offensive. The OS X state isn't really shippable. :-\

Given the change well predates the Photon work, really unsure what caused this.

Comment 4

[:Gijs (he/him)]

I suspect this is bug 1357655, based on current mozregression window. Still confirming...

Comment 5

[:Gijs (he/him)]

Yes, definitely bug 1357655.

Mats, how are we supposed to work around this? I see forms.css now sets both appearance: auto and -moz-appearance: textfield, which doesn't make much sense to me. How do we get a normal border style back on Windows and how can we remove the ugly black thing on OS X? I've tried various 'appearance' and '-moz-appearance' and 'border' incantations but nothing much seems to work. :-\

Comment 6

[Mats Palmgren (inactive)]

Can you point me to the HTML + CSS that is used for that thing in the screenshot please?

Comment 7

[Mats Palmgren (inactive)]

Or a minimal testcase would be even better... :-)

Comment 8

[Mark Hammond [:markh] [:mhammond]]

(In reply to Mats Palmgren (:mats) from comment #6)
> Can you point me to the HTML + CSS that is used for that thing in the
> screenshot please?

http://searchfox.org/mozilla-central/source/browser/components/syncedtabs/sidebar.xhtml
http://searchfox.org/mozilla-central/source/browser/themes/shared/syncedtabs/sidebar.inc.css
http://searchfox.org/mozilla-central/source/browser/themes/windows/syncedtabs/sidebar.css (and corresponding osx/linux variants)

Comment 9

[Gerry Chang [:gchang]]

Track 54+/55+ as regression.

Comment 10

[Mats Palmgren (inactive)]

Bug 1365614 backed out the 'appearance' property so '-moz-appearance' should work
exactly as before now (for both v55/v54).  Does that fix this bug?

Comment 11

[:Gijs (he/him)]

(In reply to Mats Palmgren (:mats) from comment #10)
> Bug 1365614 backed out the 'appearance' property so '-moz-appearance' should
> work
> exactly as before now (for both v55/v54).  Does that fix this bug?

Yes! Thanks. :-)

Comment 12

[Ryan Feeley [:rfeeley]]

Looks great, thanks all!

Comment 13

[Gerry Chang [:gchang]]

Since bug 1365614 was backed out, mark 54 won't fix.